Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_holidays: Add missing fields in constrains #32108

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@sswapnesh
Copy link
Contributor

commented Mar 25, 2019

Description of the issue/feature this PR addresses: Leave functionality in hr_holidays module

Current behavior before PR: Constrains _check_leave_type_validity is not called on changing Start/End date which allows Employee to use Leave type Ignoring validity configured in Leave type

Desired behavior after PR is merged: Employee cannot take out of Validity defined in Leave type configuration

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Mar 25, 2019

@robodoo robodoo added the CI 🤖 label Mar 25, 2019

@mart-e mart-e added the HR label Apr 8, 2019

@mart-e

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

cc @tivisse LGTM

@tivisse

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@robodoo robodoo added the r+ 👌 label Apr 8, 2019

@robodoo robodoo added the merging 👷 label Apr 8, 2019

@robodoo robodoo closed this in a432e5c Apr 8, 2019

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Apr 8, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

Merged, thanks!

@sswapnesh sswapnesh deleted the sswapnesh:patch-11 branch Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.