Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_sale: use sudo to check pricelist code to avoid field groups check #32111

Conversation

Projects
None yet
4 participants
@tomeyro
Copy link
Contributor

tomeyro commented Mar 26, 2019

Description of the issue/feature this PR addresses:

When a website is loaded it tries to get the available pricelists to show the user.
One of the checks is using the code of the pricelist. This field is limited to a
group according to its definition, so when the public or portal user tries to load
the website, a rule check error is raised.

Desired behavior after PR is merged:

The code is checked using sudo to avoid this group check, and the website
is correctly loaded with the expected pricelists.

--

This MR is related with issue reported at OPW-1959303.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Mar 26, 2019

@tomeyro

This comment has been minimized.

Copy link
Contributor Author

tomeyro commented Mar 26, 2019

CC: @nhomar

@nhomar nhomar requested a review from rdeodoo Mar 26, 2019

@nhomar

This comment has been minimized.

Copy link
Contributor

nhomar commented Mar 26, 2019

informative.

this error is blocking odoo.sh's instances left them unusable when website is installed.

@robodoo robodoo added the CI 🤖 label Mar 26, 2019

@nim-odoo
Copy link
Contributor

nim-odoo left a comment

robodoo r+

@robodoo robodoo added the r+ 👌 label Mar 26, 2019

@robodoo robodoo closed this in 0215b6f Mar 26, 2019

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Mar 26, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 26, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.