Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] l10n_nl: set correct VAT codes on fiscal position lines #32130

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@jco-odoo
Copy link
Contributor

jco-odoo commented Mar 26, 2019

Before this PR quite a lot of the lines on the fiscal positions
"EU landen", "Niet-EU landen" and "Installatie en Afstandsverkopen"
where mapped wrong, some of the lines even referred to another
tax percentage.

Changes:

  • The tax "BTW te vorderen laag (inkopen) 9%" on the product
    mapped to the tax to apply named "Inkopen import buiten EU laag 6%",
    which should be "Inkopen import buiten EU laag 9%" to correctly
    counterpart the taxes. All the other changes where similar,
    either invalid tax rates where applied or it mapped to a wrong category.
  • "Verkopen/omzet overig diensten" on the product would map to
    "Installatie/afstandsverkopen buiten EU" as the VAT to apply.
    This should map to "Verkopen export buiten EU".
  • Added 3 accounts for Omzet NL handelsgoederen 1,
    Omzet NL handelsgoederen 2 and Omzet NL handelsgoederen 3
  • Mapped the 3 accounts to the fiscal position
    "Installatie en Afstandsverkopen" their relevant lines.
  • Removed purchase taxes from fiscal position "Installatie en Afstandsverkopen" .
  • Mapped the right taxes to the three fiscal positions their VAT tabels.
  • Updated .pot file to add the three extra accounts.

Closes #31403

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD label Mar 26, 2019

@jco-odoo jco-odoo requested a review from nim-odoo Mar 26, 2019

@jco-odoo

This comment has been minimized.

Copy link
Contributor Author

jco-odoo commented Mar 26, 2019

@nim-odoo can you check for merging?

@robodoo robodoo added the seen 🙂 label Mar 26, 2019

@jco-odoo

This comment has been minimized.

Copy link
Contributor Author

jco-odoo commented Mar 26, 2019

Related to #31403

[FIX] l10n_nl: set correct VAT codes on fiscal position lines
Before this PR quite a lot of the lines on the fiscal positions
"EU landen", "Niet-EU landen" and "Installatie en Afstandsverkopen"
where mapped wrong, some of the lines even referred to another
tax percentage.

Changes:
- The tax "BTW te vorderen laag (inkopen) 9%" on the product
mapped to the tax to apply named "Inkopen import buiten EU laag 6%",
which should be "Inkopen import buiten EU laag 9%" to correctly
counterpart the taxes. All the other changes where similar,
either invalid tax rates where applied or it mapped to a wrong category.
- "Verkopen/omzet overig diensten" on the product would map to
"Installatie/afstandsverkopen buiten EU" as the VAT to apply.
This should map to "Verkopen export buiten EU".
- Added 3 accounts for Omzet NL handelsgoederen 1,
Omzet NL handelsgoederen 2 and Omzet NL handelsgoederen 3
- Mapped the 3 accounts to the fiscal position
"Installatie en Afstandsverkopen" their relevant lines.
- Removed purchase taxes from fiscal position "Installatie en Afstandsverkopen" .
- Mapped the right taxes to the three fiscal positions their VAT tabels.
- Updated .pot file to add the three extra accounts.

Closes #31403

@nim-odoo nim-odoo force-pushed the odoo-dev:12.0-nlfpfixes-jco branch from 49964d2 to 60ca9df Mar 26, 2019

@nim-odoo
Copy link
Contributor

nim-odoo left a comment

robodoo r+

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 26, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.