m #32134
Closed
m #32134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tivisse
force-pushed
the
master-ir-attachments-yti
branch
from
0d3347b
to
0284588
Compare
robodoo
added
CI 🤖
tivisse
force-pushed
the
master-ir-attachments-yti
branch
from
7e27693
to
d9608bf
Compare
tivisse
force-pushed
the
master-ir-attachments-yti
branch
from
dc7360f
to
7e35215
Compare
robodoo
added
CI 🤖
Now that portal users don't have access to the backend, it doesn't make sense to give the read access on attachments, as this is the role of the specific controllers to provide this access according to the business logic. For the record, these rules have been introduced at: odoo@61065b6 odoo@f3fa266
tivisse
force-pushed
the
master-ir-attachments-yti
branch
from
7e35215
to
da86bc5
Compare
robodoo
added
CI 🤖
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 29, 2019
Now that portal users don't have access to the backend, it doesn't make sense to give the read access on attachments, as this is the role of the specific controllers to provide this access according to the business logic. For the record, these rules have been introduced at: 61065b6 f3fa266 closes #32134 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr