Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] survey.stage (dynamic) replaced by static state on survey.survey #32325

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@Feyensv
Copy link

commented Apr 2, 2019

State customization of surveys through survey.stage removed.
The users won't be able to create custom survey stages anymore.
Only 3 static states are left on survey.survey (draft, open, closed)

Form : use buttons to navigate between states instead of the clickable statusbar
Kanban : don't allow survey drag&drop anymore (long-term deletion of the kanban view?)

Task ID : 1949110

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the CI 🤖 label Apr 2, 2019

@C3POdoo C3POdoo added the RD label Apr 2, 2019

@dbeguin
Copy link
Contributor

left a comment

Just a small remark, for the rest, at first look, seems ok

Show resolved Hide resolved addons/survey/models/survey_survey.py Outdated

@Feyensv Feyensv force-pushed the odoo-dev:master-survey-states-vfe branch from 61864da to ab71106 Apr 11, 2019

@robodoo robodoo removed the CI 🤖 label Apr 11, 2019

@Yenthe666

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

Wait, why would you ever do that? This is literally removing functionality and I don't see why you'd want to remove this?

@robodoo robodoo added the CI 🤖 label Apr 11, 2019

@Feyensv

This comment has been minimized.

Copy link
Author

commented Apr 11, 2019

@Yenthe666 : the debate between static states or dynamic stages isn't clearly decided in Odoo :D.
The primary spec was to update the states/stages s.t. the buttons of the survey aren't always displayed, because they led to unexpected/forbidden behavior in the current state of the module.
I proposed two solutions for this :

  1. a state (draft, open, closed) on the stages to know which actions are available for each stage (but keeping the ability for the customer to customize the survey flow with different stages) (PR #32237)
  2. a fixed state (this PR)

The internal debate led to the second choice.
Ping @sbuhl

@Yenthe666

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

@Feyensv thanks for the feedback and the insight. I can understand that point 2 is possible easier to change and handle but from the user experience this is a serious step back. I know plenty of people who use the survey module with dynamic states and they would loose this functionality in the master version. It is a pity to remove a functionality, no?

@Feyensv

This comment has been minimized.

Copy link
Author

commented Apr 11, 2019

My preference goes to the flexibility and keeping the stages, but the final decision goes to @sbuhl :D

@Yenthe666

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

@Feyensv I understand, there is always somebody above you hmm ;)
@sbuhl could you be so kind to let me/us know what is the reasoning for going with fixed stages before the flexibility of dynamic stages?

@tde-banana-odoo
Copy link
Contributor

left a comment

Tech review: globally good, some minor remarks. Thanks for your work !

Show resolved Hide resolved addons/hr_recruitment_survey/data/survey_demo.xml Outdated
Show resolved Hide resolved addons/survey/models/survey_survey.py Outdated
Show resolved Hide resolved addons/survey/models/survey_survey.py

@Feyensv Feyensv force-pushed the odoo-dev:master-survey-states-vfe branch from ab71106 to c70ebba Apr 11, 2019

@robodoo robodoo removed the CI 🤖 label Apr 11, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-survey-states-vfe branch from c70ebba to 0b3fa01 Apr 11, 2019

@robodoo robodoo added the CI 🤖 label Apr 11, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-survey-states-vfe branch from 0b3fa01 to d88a31f Apr 12, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 12, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-survey-states-vfe branch from d88a31f to 140fe07 Apr 17, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 17, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-survey-states-vfe branch from 140fe07 to 30b87b0 Apr 19, 2019

@robodoo robodoo removed the CI 🤖 label Apr 19, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-survey-states-vfe branch from 30b87b0 to edf8ebb Apr 19, 2019

@robodoo robodoo added the CI 🤖 label Apr 19, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-survey-states-vfe branch from edf8ebb to 6eebf6c Apr 24, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 24, 2019

@Feyensv Feyensv changed the title [REM] survey.stage (dynamic) replaced by static state on survey.survey [REF] survey.stage (dynamic) replaced by static state on survey.survey Apr 25, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-survey-states-vfe branch from 6eebf6c to 1fdbbe5 Apr 25, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 25, 2019

[REF] survey: replace dynamic survey.stage by a static state on surve…
…y.survey

Stages modification through the clickable statusbar wasn't very intuitive.
By fixing default behavior through states (and corresponding buttons), default user experience is simplified.

3 static states available : draft, open, closed

Form view: navigation through states with buttons
Kanban view: disabled modification of survey state

Task ID : 1949110

@Feyensv Feyensv force-pushed the odoo-dev:master-survey-states-vfe branch from 1fdbbe5 to 7b0d726 Apr 25, 2019

@robodoo robodoo removed the CI 🤖 label Apr 25, 2019

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

robodoo pushed a commit that referenced this pull request Apr 25, 2019

[REF] survey: replace dynamic survey.stage by a static state on surve…
…y.survey

Stages modification through the clickable statusbar wasn't very intuitive.
By fixing default behavior through states (and corresponding buttons), default user experience is simplified.

3 static states available : draft, open, closed

Form view: navigation through states with buttons
Kanban view: disabled modification of survey state

Task ID : 1949110

closes #32325

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Staging failed: timed out (>120 minutes)

@Xavier-Do

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Linked pull request(s) odoo/enterprise#3990 not ready. Linked PRs are not staged until all of them are ready.

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Apr 25, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.