Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Warning message about dropped view during installation #32377

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@jbm-odoo
Copy link
Contributor

commented Apr 3, 2019

This problem appears when the module l10n_be_hr_payroll_fleet is installed.
This module inherits from hr.contract and will create and modify some fields.
By modifying contract's table, PostgreSQL will drop the view from
hr_contract_employee_report. At the end of the installation, PostgreSQL will
check if tables exist, it isn't the case for the view from
hr_contract_employee_report, so it will recreate it. It's the normal behavior.
But when a table is missing, a warning is logged and create problem with
Runbot. For this reason, it's better to log an Info and not a Warning message.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the CI 🤖 label Apr 3, 2019

@C3POdoo C3POdoo added the RD label Apr 3, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 9, 2019

@RomainLibert RomainLibert requested review from rco-odoo and odony Apr 15, 2019

@jbm-odoo jbm-odoo force-pushed the odoo-dev:master-employee-reporting-jbm branch from 88d9047 to ddfafd9 Apr 15, 2019

@robodoo robodoo removed the CI 🤖 label Apr 15, 2019

@jbm-odoo jbm-odoo force-pushed the odoo-dev:master-employee-reporting-jbm branch 2 times, most recently from 5edf8fd to 4225149 Apr 15, 2019

@robodoo robodoo added the CI 🤖 label Apr 15, 2019

@tivisse tivisse force-pushed the odoo-dev:master-employee-reporting-jbm branch from 4225149 to cf8ab51 Apr 17, 2019

@robodoo robodoo removed the CI 🤖 label Apr 17, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

@robodoo rebase-ff r+

@robodoo robodoo added the r+ 👌 label Apr 17, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Merge method set to rebase and fast-forward

@robodoo robodoo added the CI 🤖 label Apr 17, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Linked pull request(s) odoo/enterprise#3963 not ready. Linked PRs are not staged until all of them are ready.

jbm-odoo added some commits Apr 3, 2019

[IMP] registry.py: Log info instead of warning about dropped view dur…
…ing installation

This problem appears when the module l10n_be_hr_payroll_fleet is installed with the
dynamic report for employees (enterprise module hr_contract_reports).

This module inherits from hr.contract and will create and modify some fields.

By modifying contract's table, PostgreSQL will drop the view from
hr_contract_employee_report. At the end of the installation, PostgreSQL will
check if tables exist, it isn't the case for the view from
hr_contract_employee_report, so it will recreate it.

It's the normal behavior.

But when a table is missing, a warning is logged and create problem with
Runbot. For this reason, it's better to log an Info and not a Warning message.

Validated with @rco
[IMP] hr(_presence): Merge reporting menu
hr_prensence add a menu 'reports' in employee app and

hr_contract_dashboard add a 'Reporting' menu.

Merge both together.

@tivisse tivisse force-pushed the odoo-dev:master-employee-reporting-jbm branch from cf8ab51 to 16d8683 Apr 18, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

robodoo pushed a commit that referenced this pull request Apr 18, 2019

[IMP] hr(_presence): Merge reporting menu
hr_prensence add a menu 'reports' in employee app and

hr_contract_dashboard add a 'Reporting' menu.

Merge both together.

closes #32377

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 18, 2019

@tivisse tivisse deleted the odoo-dev:master-employee-reporting-jbm branch Apr 18, 2019

Arcasias added a commit to odoo-dev/odoo that referenced this pull request Apr 19, 2019

[IMP] hr(_presence): Merge reporting menu
hr_prensence add a menu 'reports' in employee app and

hr_contract_dashboard add a 'Reporting' menu.

Merge both together.

closes odoo#32377

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.