Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] web_tour: add a startTour helper on odoo #32441

Closed
wants to merge 1 commit into from

Conversation

d-fence
Copy link
Contributor

@d-fence d-fence commented Apr 5, 2019

As a start_tour helper was added on the python side (PR #32316),
a javascript helper was needed as suggested on the PR.

@C3POdoo C3POdoo added the RD research & development, internal work label Apr 5, 2019
@ged-odoo
Copy link
Contributor

ged-odoo commented Apr 5, 2019

see my comment odoo-dev@2f64187#commitcomment-33046777

@d-fence
Copy link
Contributor Author

d-fence commented Apr 5, 2019

As always, your solution is far simpler. Thanks

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 5, 2019
As a start_tour helper was added on the python side (PR odoo#32316),
a javascript helper counterpart was needed as suggested on the PR.
@d-fence d-fence changed the title [IMP] web: add a startTour helper on odoo [IMP] web_tour: add a startTour helper on odoo Apr 5, 2019
Copy link
Contributor

@seb-odoo seb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestions

@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Apr 5, 2019
@ged-odoo
Copy link
Contributor

ged-odoo commented Apr 5, 2019

looking good to me. not sure if you expect me to robodoo r+ this...

@d-fence
Copy link
Contributor Author

d-fence commented Apr 5, 2019

no, I can do it :-)
@robodoo r+

@robodoo robodoo added the r+ 👌 label Apr 5, 2019
robodoo pushed a commit that referenced this pull request Apr 5, 2019
As a start_tour helper was added on the python side (PR #32316),
a javascript helper counterpart was needed as suggested on the PR.

closes #32441

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
@robodoo
Copy link
Contributor

robodoo commented Apr 5, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 5, 2019
@fw-bot fw-bot deleted the master-start-tour-js-moc branch October 19, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants