[IMP] website: improvements in optimize SEO dialog #32449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthchoksi-github
force-pushed
the
master-seo-dialog-pch
branch
from
0c96a68
to
c97667f
Compare
added 3 commits
April 5, 2019 17:04
Before this commit, In dialog box of Optimize SEO, we were getting 2 previews. This fix will remove the rendering of extra preview. Task ID:1949636
Before this commit, In SEO dialog once you set the title and description, it was not possible to reset title and description. The reason behind the issue was, update method was taking title and description from DOM instead of dialog inputs. After this commit, you will be able to save empty strings in the title and description. Once user will do this, the page will use default title. Task ID:1949636
In this commit, we have changed behaviour of SEO dialog. Now when you keep title and description fields empty, then the page will use default title and description. We have added default_title and default_description to render the preview with default values when title and description fields are empty in SEO dialog. Task ID:1949636
parthchoksi-github
force-pushed
the
master-seo-dialog-pch
branch
from
c97667f
to
01ee308
Compare
|
@robodoo r+ |
|
Because this PR has multiple commits, I need to know how to merge it:
|
|
@robodoo rebase-ff |
|
Merge method set to rebase and fast-forward |
robodoo
pushed a commit
that referenced
this pull request
Apr 16, 2019
In this commit, we have changed behaviour of SEO dialog. Now when you keep title and description fields empty, then the page will use default title and description. We have added default_title and default_description to render the preview with default values when title and description fields are empty in SEO dialog. Task ID:1949636 closes #32449 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements in behaviour of Optimize SEO dialog
After this PR is merged, when you keep title and description fields empty, then the page will use default title and description. We have added default_title and default_description to render the preview with default values when title and description fields are empty in SEO dialog.
A fix has been done on rendering of the 'Preview' in SEO dialog. Earlier 2 previews were being shown, now we've removed the extra one.
Some minor amendments like adding placeholders to title and description and renaming of second preview of SEO dialog to "Social Preview".
Task Link: https://www.odoo.com/web?debug#id=1949636&action=327&model=project.task&view_type=form&menu_id=4720
Pad Link: https://pad.odoo.com/p/r.6991f9e0448188a816cbbc85672ada39
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr