Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_sale: fix double click on add to cart #32479

Closed

Conversation

Projects
None yet
2 participants
@qsm-odoo
Copy link
Contributor

qsm-odoo commented Apr 8, 2019

Using "async" in the event parameter is not enough, you have to
return correct promises in the event handlers.

@qsm-odoo qsm-odoo self-assigned this Apr 8, 2019

@robodoo robodoo added the seen 🙂 label Apr 8, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor Author

qsm-odoo commented Apr 8, 2019

Following 55ed70f

@qsm-odoo

This comment has been minimized.

Copy link
Contributor Author

qsm-odoo commented Apr 8, 2019

@robodoo robodoo added the r+ 👌 label Apr 8, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 8, 2019

'ci/runbot' failed on this reviewed PR.

2 similar comments
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 8, 2019

'ci/runbot' failed on this reviewed PR.

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 9, 2019

'ci/runbot' failed on this reviewed PR.

@qsm-odoo qsm-odoo force-pushed the odoo-dev:saas-12.3-fix-async-add-to-cart-qsm branch from 16ab834 to a88d270 Apr 16, 2019

@robodoo robodoo removed the r+ 👌 label Apr 16, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor Author

qsm-odoo commented Apr 16, 2019

@robodoo robodoo added the r+ 👌 label Apr 16, 2019

robodoo pushed a commit that referenced this pull request Apr 16, 2019

[FIX] website_sale: fix double click on add to cart
Using "async" in the event parameter is not enough, you have to
return correct promises in the event handlers.

closes #32479

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 16, 2019

Staging failed: ci/runbot on 7bb9e72242e247c181c11ac89ae64bd03e70b02c (view more at http://runbot.odoo.com/runbot/build/500924)

@qsm-odoo

This comment has been minimized.

Copy link
Contributor Author

qsm-odoo commented Apr 17, 2019

@robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Apr 17, 2019

robodoo pushed a commit that referenced this pull request Apr 17, 2019

[FIX] website_sale: fix double click on add to cart
Using "async" in the event parameter is not enough, you have to
return correct promises in the event handlers.

closes #32479

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

@robodoo robodoo added merging 👷 and removed r+ 👌 CI 🤖 labels Apr 17, 2019

@robodoo robodoo added error 🙅 and removed merging 👷 labels Apr 17, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 17, 2019

Staging failed: ci/runbot on a6f50ececd5a26dc56742196d6c3fa0cf3e3887c (view more at http://runbot.odoo.com/runbot/build/501754)

[FIX] website_sale: fix double click on add to cart
Using "async" in the event parameter is not enough, you have to
return correct promises in the event handlers.

@qsm-odoo qsm-odoo force-pushed the odoo-dev:saas-12.3-fix-async-add-to-cart-qsm branch from a88d270 to 564f7ae Apr 19, 2019

@robodoo robodoo removed the error 🙅 label Apr 19, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor Author

qsm-odoo commented Apr 19, 2019

@robodoo robodoo added the r+ 👌 label Apr 19, 2019

robodoo pushed a commit that referenced this pull request Apr 19, 2019

[FIX] website_sale: fix double click on add to cart
Using "async" in the event parameter is not enough, you have to
return correct promises in the event handlers.

closes #32479

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 19, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 19, 2019

@qsm-odoo qsm-odoo deleted the odoo-dev:saas-12.3-fix-async-add-to-cart-qsm branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.