Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] map view #32487

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@ThomasWerland
Copy link

commented Apr 8, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Apr 8, 2019

@C3POdoo C3POdoo added the RD label Apr 8, 2019

@robodoo robodoo added the CI 🤖 label Apr 8, 2019

@ThomasWerland ThomasWerland force-pushed the odoo-dev:master-map-view-twe branch from b375551 to a7226fb Apr 17, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 17, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 2, 2019

Map
===

This view is able to display records on a map and the routes between them. The record are represented by pins. It also allows the visualization of fields from the model in a popup tied to the record's pin. The model on which the view is applied should contains a res.partner many2one since the view relies on the res.partner's address and coordinates fields to localize the records.

This comment has been minimized.

Copy link
@VincentSchippefilt

VincentSchippefilt May 3, 2019

Contributor

"The model on which the view is applied should contains a res.partner many2one since the view relies on the res.partner's address and coordinates fields to localize the records." add emphasis

Api
---

The view uses an api to fetch the tiles (the map's background), do the geoforwarding (converting addresses to a set of coordinates) and fetch the routes.

This comment has been minimized.

Copy link
@VincentSchippefilt

VincentSchippefilt May 3, 2019

Contributor

"an api" is not specific, be specific

---

The view uses an api to fetch the tiles (the map's background), do the geoforwarding (converting addresses to a set of coordinates) and fetch the routes.
The view implements two api, the default one, openstreet map is able to fetch tiles and do geoforwarding. This api does not require a token.

This comment has been minimized.

Copy link
@VincentSchippefilt

VincentSchippefilt May 3, 2019

Contributor

add links to external ressources: openstreet map, mapbox, mapbox api


Structural components
---------------------

This comment has been minimized.

Copy link
@VincentSchippefilt

VincentSchippefilt May 3, 2019

Contributor

missing an example


Structural components
---------------------

This comment has been minimized.

Copy link
@VincentSchippefilt

VincentSchippefilt May 3, 2019

Contributor

Also mention what is mandatory and what is optional

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 3, 2019

@ThomasWerland ThomasWerland force-pushed the odoo-dev:master-map-view-twe branch from eea1af1 to 46f2d29 May 3, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 3, 2019

@ThomasWerland ThomasWerland force-pushed the odoo-dev:master-map-view-twe branch 2 times, most recently from 5ff2fcd to b022894 May 6, 2019

@robodoo robodoo added the CI 🤖 label May 9, 2019

@ThomasWerland ThomasWerland force-pushed the odoo-dev:master-map-view-twe branch from b022894 to 81c3215 May 9, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 9, 2019

@VincentSchippefilt VincentSchippefilt force-pushed the odoo-dev:master-map-view-twe branch from 81c3215 to 50e4931 May 15, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 15, 2019

[IMP] base_geolocalize,web_editor,doc: create map_view
In order for the map view to work properly:
- I moved scss property to a  file only scoped to website module.
- moved the definiton of "partner_latitude" and "partner_longitude" from
base_geolocalise to base/res.partner

@VincentSchippefilt VincentSchippefilt force-pushed the odoo-dev:master-map-view-twe branch from 50e4931 to 035f8b8 May 15, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.