Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master choose lang url pla #32552

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@pla-odoo
Copy link
Contributor

pla-odoo commented Apr 9, 2019

Description of the issue/feature this PR addresses:
Task link: https://www.odoo.com/web?debug#id=32838&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Apr 9, 2019

@C3POdoo C3POdoo added the RD label Apr 9, 2019

@robodoo robodoo added the CI 🤖 label Apr 9, 2019

@JKE-be

This comment has been minimized.

Copy link
Contributor

JKE-be commented Apr 11, 2019

I just take a quick look on your branch.

But seems like you still have some mixte between code/request_lang.

Eg: the preferred langage will return the code, while you will check if it match a request_lang
https://github.com/odoo/odoo/pull/32552/files#diff-1098b36b5b4beaccedda81a4b67e22e1R299

url for seems also bugged:
image

How can you change the website_lang_code actually in the UI ?

Please can you add test that cover these case.
You can cherry-pick the commit 8557bcf into your branch.
With this commit, you can easily check the url_for and use the Mock done in the test to add your own test.

thank you

@robodoo robodoo removed the CI 🤖 label Apr 11, 2019

@pla-odoo pla-odoo force-pushed the odoo-dev:master-choose-lang-url-pla branch 5 times, most recently from ab682c9 to e31f5d5 Apr 11, 2019

@mba-odoo mba-odoo force-pushed the odoo-dev:master-choose-lang-url-pla branch from e31f5d5 to f57b220 Apr 16, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 16, 2019

@mba-odoo mba-odoo force-pushed the odoo-dev:master-choose-lang-url-pla branch 2 times, most recently from eac3323 to de53f24 Apr 17, 2019

@robodoo robodoo added the CI 🤖 label Apr 17, 2019

@mba-odoo mba-odoo force-pushed the odoo-dev:master-choose-lang-url-pla branch from de53f24 to c2854f8 Apr 18, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.