Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_livechat: fix error when no ratings #32553

Conversation

Projects
None yet
4 participants
@pka-odoo
Copy link
Contributor

commented Apr 9, 2019

Description of the issue/feature this PR addresses:
Getting traceback while publishing livechat channel on website

Current behavior before PR:
Getting traceback while publishing livechat channel on website

Desired behavior after PR is merged:
traceback resolved while publishing livechat channel on website

Issue:
https://www.odoo.com/web#id=1966384&action=327&model=project.task&view_type=form&menu_id=4720

Pad:
https://pad.odoo.com/p/r.7ecd3243267fff80dba85cfa95a3da62

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the CI 🤖 label Apr 9, 2019

@C3POdoo C3POdoo added the RD label Apr 9, 2019

@pka-odoo pka-odoo force-pushed the odoo-dev:saas-12.2-website_livechat-channel-publish-issue-pka branch from 7258b7c to 8ae4960 Apr 10, 2019

@robodoo robodoo removed the CI 🤖 label Apr 10, 2019

@pka-odoo pka-odoo force-pushed the odoo-dev:saas-12.2-website_livechat-channel-publish-issue-pka branch 2 times, most recently from 8cb214b to 3a4f050 Apr 10, 2019

@robodoo robodoo added the CI 🤖 label Apr 10, 2019

[FIX] website_livechat: fix error when no ratings
If there is no rating for user, it will throw error while publishing channel.
This commit check if there is any rating for particular user or not.

Introduced by ce20c29

opw-1966384

@rdeodoo rdeodoo force-pushed the odoo-dev:saas-12.2-website_livechat-channel-publish-issue-pka branch from 3a4f050 to c79d171 Apr 16, 2019

@robodoo robodoo removed the CI 🤖 label Apr 16, 2019

@rdeodoo rdeodoo changed the base branch from saas-12.2 to saas-12.1 Apr 16, 2019

@JKE-be

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

@robodoo robodoo added the r+ 👌 label Apr 16, 2019

robodoo pushed a commit that referenced this pull request Apr 16, 2019

[FIX] website_livechat: fix error when no ratings
If there is no rating for user, it will throw error while publishing channel.
This commit check if there is any rating for particular user or not.

Introduced by ce20c29

opw-1966384

closes #32553

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 16, 2019

@rdeodoo rdeodoo deleted the odoo-dev:saas-12.2-website_livechat-channel-publish-issue-pka branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.