Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sale_timesheet: profitability report #32554

Conversation

Projects
None yet
4 participants
@gla-odoo
Copy link

gla-odoo commented Apr 9, 2019

In the Project Overview, the Profitability report takes into account
Timesheet costs, but doesn't include information on Revenue.
Because of that, the user is missing crucial information to determine
the profitability of a given project.

This PR aims at fixing this issue by sending the user to the
'Project Costs and Revenues' report of the concerned project when
clicking the 'Profitability' button within the Project Overview page.

It also fixes a tiny labelling typo.

Task-1963932

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD label Apr 9, 2019

@jem-odoo
Copy link
Contributor

jem-odoo left a comment

Small remarks

gla-odoo added some commits Apr 15, 2019

[IMP] sale_timesheet: fix typo
Fix a tiny typo in sale_timesheet.

Task-1963932
[IMP] sale_timesheet: profitability report
In the Project Overview, the Profitability report takes into account
Timesheet costs, but doesn't include information on Revenue.
Because of that, the user is missing crucial information to determine
the profitability of a given project.

This commit aims at fixing this issue by sending the user to the
'Project Costs and Revenues' report of the concerned project when
clicking the 'Profitability' button within the Project Overview page.

Task-1963932

@gla-odoo gla-odoo force-pushed the odoo-dev:master-sale-timesheet-revenue-overview-gla branch from 2a3d428 to 622e5eb Apr 15, 2019

@robodoo robodoo removed the CI 🤖 label Apr 15, 2019

@gla-odoo

This comment has been minimized.

Copy link
Author

gla-odoo commented Apr 15, 2019

I pushed the changes, tell me if still problematic!

@robodoo robodoo added the CI 🤖 label Apr 15, 2019

@jem-odoo
Copy link
Contributor

jem-odoo left a comment

LGTM

@jem-odoo

This comment has been minimized.

Copy link
Contributor

jem-odoo commented Apr 16, 2019

@robodoo rebase-ff r+

@robodoo robodoo added the r+ 👌 label Apr 16, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 16, 2019

Merge method set to rebase and fast-forward

robodoo pushed a commit that referenced this pull request Apr 16, 2019

[IMP] sale_timesheet: profitability report
In the Project Overview, the Profitability report takes into account
Timesheet costs, but doesn't include information on Revenue.
Because of that, the user is missing crucial information to determine
the profitability of a given project.

This commit aims at fixing this issue by sending the user to the
'Project Costs and Revenues' report of the concerned project when
clicking the 'Profitability' button within the Project Overview page.

Task-1963932

closes #32554

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Apr 16, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 16, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.