[FIX] point_of_sale: lost pos orders on IntegrityError #32577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This revision is similar to 605b94e except that instead of an OperationalError (e.g. a conccurent update), this is an IntegrityError which is raised, an sql constraint which is not met, e.g. a unique or required constraint. In the case of this opw, this is the picking name unique constraint which was not met, the picking sequence number has somehow been re-used. Both `psycopg2.OperationalError` and `psycopg2.IntegrityError` inherits from `psycopg2.DatabaseError` We therefore choose to use this Exception class, to include all kind of psycopg2 exceptions that prevent the transaction to be committed. opw-1965679
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 10, 2019
This revision is similar to 605b94e except that instead of an OperationalError (e.g. a conccurent update), this is an IntegrityError which is raised, an sql constraint which is not met, e.g. a unique or required constraint. In the case of this opw, this is the picking name unique constraint which was not met, the picking sequence number has somehow been re-used. Both `psycopg2.OperationalError` and `psycopg2.IntegrityError` inherits from `psycopg2.DatabaseError` We therefore choose to use this Exception class, to include all kind of psycopg2 exceptions that prevent the transaction to be committed. opw-1965679 closes #32577 Signed-off-by: Denis Ledoux <beledouxdenis@users.noreply.github.com>
robodoo
added
CI 🤖
|
Merged, thanks! |
|
@beledouxdenis maybe you could take a look at #27684, please. It's unrelated to this PR but does an identical fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revision is similar to
605b94e
except that instead of an OperationalError
(e.g. a conccurent update),
this is an IntegrityError which is raised,
an sql constraint which is not met,
e.g. a unique or required constraint.
In the case of this opw,
this is the picking name unique constraint
which was not met,
the picking sequence number has somehow been re-used.
Both
psycopg2.OperationalErrorand
psycopg2.IntegrityErrorinherits from
psycopg2.DatabaseErrorWe therefore choose to use this Exception class,
to include all kind of psycopg2 exceptions that prevent
the transaction to be committed.
opw-1965679