Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[FIX] im_livechat, web: safely open image with placeholder #32664
seb-odoo left a comment
I tested the PR and this fixes the issue.
I'm not really sure about the code though. I made my comments as if we are doing it this way but I'm not sure it is the best one.
@odony I'm not 100% convinced about the need to duplicate the method, I feel like we are adding more complexity which can ultimately lead to making more (security) mistakes.
I do like the idea of having one method for handling images though, especially since the code it would contain has also been copied in other places such as
Maybe just fix the