Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] crm_iap_lead*: generic improvements #32676

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@pro-odoo
Copy link
Contributor

pro-odoo commented Apr 15, 2019

Improve the usability of crm_iap_lead and crm_iap_lead_website.

Task-ID 1965687

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Apr 15, 2019

@C3POdoo C3POdoo added the RD label Apr 15, 2019

@pro-odoo pro-odoo force-pushed the odoo-dev:master-iap-stuff-pro branch from 8f5680e to 4358961 Apr 16, 2019

@robodoo robodoo added the CI 🤖 label Apr 16, 2019

@pro-odoo pro-odoo requested a review from pimodoo Apr 17, 2019

@pimodoo

This comment has been minimized.

Copy link
Contributor

pimodoo commented Apr 17, 2019

Change commit message to something like:
"[IMP] crm_iap_lead: improve credits consumed feedback"
To be able to correctly translate the information message on consumed credits, we are building those message in python in a computed field instead of blablbablablabla....

[IMP] crm_iap_lead*: improve credits consumed feedback
To be able to correctly translate the information message on consumed credits, we are building those message in python in a computed field instead of building in xml with four computed fields.

Task-ID 1965687

@pro-odoo pro-odoo force-pushed the odoo-dev:master-iap-stuff-pro branch from 4358961 to ee58e76 Apr 18, 2019

@robodoo robodoo removed the CI 🤖 label Apr 18, 2019

@pimodoo

This comment has been minimized.

Copy link
Contributor

pimodoo commented Apr 18, 2019

robodoo r+ rebase-ff

@robodoo robodoo added the r+ 👌 label Apr 18, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 18, 2019

Merge method set to rebase and fast-forward

@robodoo robodoo added the CI 🤖 label Apr 18, 2019

robodoo pushed a commit that referenced this pull request Apr 18, 2019

[IMP] crm_iap_lead*: improve credits consumed feedback
To be able to correctly translate the information message on consumed credits, we are building those message in python in a computed field instead of building in xml with four computed fields.

Task-ID 1965687

closes #32676

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 18, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 18, 2019

Arcasias added a commit to odoo-dev/odoo that referenced this pull request Apr 19, 2019

[IMP] crm_iap_lead*: improve credits consumed feedback
To be able to correctly translate the information message on consumed credits, we are building those message in python in a computed field instead of building in xml with four computed fields.

Task-ID 1965687

closes odoo#32676

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.