Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mail: File deletion on module uninstallation #32682

Conversation

Projects
None yet
6 participants
@Julien00859
Copy link
Contributor

Julien00859 commented Apr 15, 2019

Commit 262e001 introduced thread, message, and attachments deletion on a
module uninstallation. When removing attachments it was also removing
files in the filestore even if those files were still in use by other
attachments.

opw-1968117

@Julien00859 Julien00859 requested review from adr-odoo and Elkasitu Apr 15, 2019

@C3POdoo C3POdoo added the OE label Apr 15, 2019

@Julien00859 Julien00859 removed the request for review from adr-odoo Apr 15, 2019

@adr-odoo
Copy link
Contributor

adr-odoo left a comment

262e001, I didn't find any reference for this commit...

@Julien00859

This comment has been minimized.

Copy link
Contributor Author

Julien00859 commented Apr 15, 2019

Weird... #30798

[FIX] mail: File deletion on module uninstallation
PR #30798 introduced thread, message, and attachments deletion on a
module uninstallation. When removing attachments it was also removing
files in the filestore even if those files were still in use by other
attachments.

opw-1968117

@Julien00859 Julien00859 force-pushed the odoo-dev:12.0-opw-1968117-uninstall_remove_att-juc branch from 26d3a44 to c291924 Apr 15, 2019

@robodoo robodoo removed the CI 🤖 label Apr 15, 2019

@Julien00859

This comment has been minimized.

Copy link
Contributor Author

Julien00859 commented Apr 15, 2019

Hello @nim-odoo can you r+ ?

@nim-odoo

This comment has been minimized.

Copy link
Contributor

nim-odoo commented Apr 15, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 15, 2019

[FIX] mail: File deletion on module uninstallation
PR #30798 introduced thread, message, and attachments deletion on a
module uninstallation. When removing attachments it was also removing
files in the filestore even if those files were still in use by other
attachments.

opw-1968117

closes #32682

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Apr 15, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.