Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] l10n_fr_pos_cert: fpos settings #32701

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@nim-odoo
Copy link
Contributor

commented Apr 16, 2019

opw-1969009

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@nim-odoo nim-odoo self-assigned this Apr 16, 2019

@C3POdoo C3POdoo added the OE label Apr 16, 2019

[FIX] l10n_fr_pos_cert: fpos settings
The computation of hash integrity depends on the field
`tax_ids_after_fiscal_position`. However, this field is computed, but
not stored.

It means that if one modifies a fiscal position used in the POS, the
computation of `tax_ids_after_fiscal_position` will change.
Consequently, the hash computation of the order will be modified, and
the hash integrity of the journal will be corrupted.

We prevent the modification of the taxes implied in a fiscal position if
any POS order use it.

Closes #32665
opw-1969009

@nim-odoo nim-odoo force-pushed the odoo-dev:10.0-opw-1969009-cert-nim branch from ee5e470 to 527932c Apr 16, 2019

@robodoo robodoo removed the CI 🤖 label Apr 16, 2019

@nim-odoo nim-odoo requested a review from kebeclibre Apr 16, 2019

@robodoo robodoo added the CI 🤖 label Apr 16, 2019

@legalsylvain

This comment has been minimized.

Copy link

commented on 527932c Apr 16, 2019

Hi @nim-odoo, Thanks a lot for this patch !

_inherit = "account.fiscal.position"

def write(self, vals):
if "tax_ids" in vals:

This comment has been minimized.

Copy link
@fmdl

fmdl Apr 16, 2019

Contributor

maybe need to make this check only on FR company, no ?

@nim-odoo
Copy link
Contributor Author

left a comment

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 17, 2019

[FIX] l10n_fr_pos_cert: fpos settings
The computation of hash integrity depends on the field
`tax_ids_after_fiscal_position`. However, this field is computed, but
not stored.

It means that if one modifies a fiscal position used in the POS, the
computation of `tax_ids_after_fiscal_position` will change.
Consequently, the hash computation of the order will be modified, and
the hash integrity of the journal will be corrupted.

We prevent the modification of the taxes implied in a fiscal position if
any POS order use it.

Closes #32665
opw-1969009

closes #32701

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/501697)

@nim-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Staging failed: ci/runbot on d5a36cb19cb82d1bb0e7a69f4bb0d0c4f3026b2b (view more at http://runbot.odoo.com/runbot/build/501724)

@robodoo robodoo added the error 🙅 label Apr 17, 2019

@nim-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Staging failed: ci/runbot on 448f9b29a81da8d04560251a74b60e14ae05e5ad (view more at http://runbot.odoo.com/runbot/build/501795)

@nim-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

robodoo retry

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 17, 2019

@nim-odoo nim-odoo deleted the odoo-dev:10.0-opw-1969009-cert-nim branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.