[FIX] l10n_fr_pos_cert: fpos settings #32701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The computation of hash integrity depends on the field `tax_ids_after_fiscal_position`. However, this field is computed, but not stored. It means that if one modifies a fiscal position used in the POS, the computation of `tax_ids_after_fiscal_position` will change. Consequently, the hash computation of the order will be modified, and the hash integrity of the journal will be corrupted. We prevent the modification of the taxes implied in a fiscal position if any POS order use it. Closes odoo#32665 opw-1969009
nim-odoo
force-pushed
the
10.0-opw-1969009-cert-nim
branch
from
ee5e470
to
527932c
Compare
fmdl
reviewed
Apr 16, 2019
| _inherit = "account.fiscal.position" | ||
|
|
||
| def write(self, vals): | ||
| if "tax_ids" in vals: |
There was a problem hiding this comment.
maybe need to make this check only on FR company, no ?
robodoo
pushed a commit
that referenced
this pull request
Apr 17, 2019
The computation of hash integrity depends on the field `tax_ids_after_fiscal_position`. However, this field is computed, but not stored. It means that if one modifies a fiscal position used in the POS, the computation of `tax_ids_after_fiscal_position` will change. Consequently, the hash computation of the order will be modified, and the hash integrity of the journal will be corrupted. We prevent the modification of the taxes implied in a fiscal position if any POS order use it. Closes #32665 opw-1969009 closes #32701 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
|
Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/501697) |
|
robodoo retry |
|
Staging failed: ci/runbot on d5a36cb19cb82d1bb0e7a69f4bb0d0c4f3026b2b (view more at http://runbot.odoo.com/runbot/build/501724) |
|
robodoo retry |
|
Staging failed: ci/runbot on 448f9b29a81da8d04560251a74b60e14ae05e5ad (view more at http://runbot.odoo.com/runbot/build/501795) |
|
robodoo retry |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opw-1969009
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr