Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master bom csv structure generation improvement anr #32702

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

anr-odoo
Copy link
Contributor

Allow the user to export the XLS file from the 'Bom Structure and cost' report

Task : https://www.odoo.com/web#id=1875706&action=327&model=project.task&view_type=form&menu_id=4720

Pad : https://pad.odoo.com/p/r.fed3d65fa6e79b78859b25689cf7596c

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD research & development, internal work label Apr 16, 2019
- icon displayed next to field if user haven't set timezone
- added relevant tooltip
- test case added for field not set alert

Task: #1916132
Closes: odoo#29448

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
@anr-odoo anr-odoo force-pushed the master-bom-csv-structure-generation-improvement-anr branch from 24bfa3d to 7d07160 Compare June 5, 2019 07:33
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jun 5, 2019
@anr-odoo anr-odoo force-pushed the master-bom-csv-structure-generation-improvement-anr branch from 7d07160 to 26a0b84 Compare June 6, 2019 07:30
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 6, 2019
@anr-odoo anr-odoo force-pushed the master-bom-csv-structure-generation-improvement-anr branch from 26a0b84 to 5aac88d Compare June 6, 2019 10:00
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 6, 2019
@anr-odoo anr-odoo force-pushed the master-bom-csv-structure-generation-improvement-anr branch from 5aac88d to 1d3952d Compare June 6, 2019 13:30
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 6, 2019
@anr-odoo anr-odoo force-pushed the master-bom-csv-structure-generation-improvement-anr branch from 1d3952d to c7205a8 Compare June 7, 2019 05:29
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Jun 7, 2019
MaxLarue and others added 11 commits June 6, 2019 07:54
When creating or editing an expense report, we have to select the corresponding
expenses. Since it is constrained that these expenses belong to the same
employee as the one from the report, it is not practical to see other
expenses in the dialog when adding them.

This commit extend the domai of the field in the expense report form so
that it doesn't show expenses from other employees.

task #1999537

closes odoo#33932

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
As the bank account should be linked to the same partner than the
address_home_id, it makes no sense to display it if this field is not
set.
In the settings, align the link 'buy credits' to the left.

Task-ID: 2007611

closes odoo#34027

Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
mrp_plm in OE uses the child_bom and prod_id from lines obtains
by _get_pdf_line in the case of a pdf report. It was already pass
by _get_bom_lines with the html report. It implies that the pdf and
html report could be different.

Task : 1939278
Closes odoo#32340
When using the print unfolded button, it will print only 1 product
and not the selected quantity on the report.

Task: 1939278

closes odoo#32340

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Context:
After a module update, the records present in ir_model_data table but not in
self.pool.loaded_xmlids are considered as no longer needed and should be
removed.
An exception is done with noupdate=true entries.

Bug 1:
Entries with noupdate=NULL are not considered in the evaluation and are ignored
while it may be worth deleting.

Bug 2:
Some records with their external id being automatically created are not present
in self.pool.loaded_xmlids and may get removed after updating a module.

By a lucky coincidence, bug 1 make it so that records targeted by bug 2 are
ignored and not deleted (the "automagically" created ir.model.data often lack
a noupdate value).

Fix Bug 1:
Use a COALESCE to find both records with noupdate=NULL and noupdate=false

Fix Bug 2:
Depends on the source of the generated external id:

- ir.model:
The entries created through _reflect_model were not loaded in
self.loaded_xmlids
Use the proper ORM method _update_xmlids that correctly populates
self.pool.loaded_xmlids

- ir.model.category:
The categories were generated when the db was initalised, doing SQL was not
avoidable.
Create the categories in noupdate to avoid it being considered for removal.

- ir.property:
Are always created in noupdate in data files but in stock_account it was
manually created without being in noupdate

closes odoo#32881

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>


Co-authored-by: Raphael Collet <rco@odoo.com>
* base

Before this commit, if an option was customized thanks to the customize
dialog, the page was not reloaded, only the new scss <link/> elements
were retrieved and replaced in the DOM.
There were two problems with this:
- The <script/> and <style/> tags were also retrieved for no reason (as
the whole result of t-call-assets was returned)
- This made use of a deprecated ir.qweb method that we want to remove
(see odoo#33432)

This commit removes the use of the deprecated method by improving the
system: only the <link/>'s new URLs are returned on customization.

closes odoo#34040

Signed-off-by: Romain Derie (rde) <rde@odoo.com>
When talking via the Live Chat to a known partner,
should be able to see his country with his name to avoid checking
the partner view form to get that information.

And improving a test case, in which we're checking for the known partner's
country name along with his name in the chat window title.

task-1940407
closes odoo#31346

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
Purpose
=======

From a busines point of view

Integration with accounting. A period of pay include journal entries and
payments. We need to generate both from a batch.

The entries must be grouped
- 1 line for salaries
- 1 line for all ATN
- ...

Payroll generate a Sepa document to send to the bank

+ as this part is managed by an accountant add menu entries in the
accounting app.

From a functional point of view:

Debit and credit accounts are defined on the rules (hr.salary.rule)
The journal should be defined on the structure to be foced

Specification
=============

- Usability: the module l10n_be_hr_payroll Should install the accounting
(right now it install invoicing). On the structure, add a journal m2o.

- On rule: add group accouting items on salary rule

- Improve method 'action_payslip_done' to support multiple entries by move.
Generate only one big entry with all payslip. Generate one total line total
for reconciable if group is set.
Now the payslips are no longer calculated individually,
all accounting entries are grouped together when the pay slips are
validated.
This allows you to have a single accounting entry for all validated
payroll records.

- Buttons on batch
- Add 2 buttons on the batch form
- "Create Entry": it will generate a grouped entries according config of
the rule
- "Payment": it generate an xml with all line to send to the bank
See https://www.odoo.com/documentation/user/11.0/accounting/receivables/customer_payments/payment_sepa.html
- Payroll directly generate the xml (no payments in accounting)

- Button on payslips: Everything should be done through the payslips
- create draft entry
- Create SEPA payment xml
- Make appear those buttons on the form only if batch is not set

- Belgian rules for the entries:
- In data for Belgium: https://docs.google.com/spreadsheets/d/1HlnwoExR_O833sij01p7UizSkrMqcm6oF4GvOeIz5lg/edit#gid=0
example of one of our OD: https://drive.google.com/file/d/0B_hhLmdks1wEdXZSQzJIeVBDOXNiNVctczJzUTBQZVBuNkgw/view?usp=sharing

- Create a Journal salaries (type miscelaneous) and apply all structure on
this journal

- Create new accounts to manage this.

- Sepa for payroll should be an option in the setting of payroll
(like in accounting)

- Configure the accounts on the rules when setting a CoA on a company.

Now the payslips are no longer calculated individually,
all accounting entries are grouped together when the pay slips are
validated.

This allows you to have a single accounting entry for all validated
payroll records.

Other notable point in this commit:
- When installing the Belgian Localisation or when installing the
Belgian CoA on a company, configure the accounting data (journal,
accounts on the salary rules)
- Don't create automatically a payslip batch when creating a payslip

TaskID: 1935200

closes odoo#32924

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Courtesy of @Yenthe666

This commit closes odoo#32580

closes odoo#34039

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
@anr-odoo anr-odoo force-pushed the master-bom-csv-structure-generation-improvement-anr branch from c7205a8 to 249af31 Compare June 12, 2019 05:17
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jun 12, 2019
A new dependency (`polib`) has been added in commit:
a762113

Since it is used in the part of the code that is copied to the IoTBox,
we need to add it to the list of packages that are installed during the
build of the image.

closes odoo#33990

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
var-odoo and others added 2 commits June 12, 2019 09:26
Purpose of the commit is when writing feedback on an activity it
doesn't have a line break in it so feedback was printed in a single line.

After this commit feedback will support line break.

Split the line by '\n' in feedback xml template to avoid t-raw.
Avoid `preventDefault` in kanban record when hitting <ENTER> on a textarea.

Task #1965831

closes odoo#33212

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
Allow to create a specific procurement group for
each so line. The purpose for different group is to
have a specific behavior for each delivery depending
it's group. It also allow to pass extra values to
procurement group creation that would be common between
multiple line (instead of passing the common values to
each lines values argument).

closes odoo#33765

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
@anr-odoo anr-odoo force-pushed the master-bom-csv-structure-generation-improvement-anr branch from 249af31 to 6753aa9 Compare June 12, 2019 09:47
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 12, 2019
@anr-odoo anr-odoo force-pushed the master-bom-csv-structure-generation-improvement-anr branch from 6753aa9 to d386881 Compare June 12, 2019 13:02
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 12, 2019
rdeodoo and others added 8 commits June 12, 2019 14:02
The _get_asset method was deprecated since df4072b
Last use of this deprecated method was removed with d7da1d6

Also, remains and to_html were deprecated since 9cd982b
test_assetsbundle was still using the deprecated method to test..

Closes odoo#33432

Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Purpose
=======

An employee and its current contract should have the same
calendar. Currently, if the contract's calendar is changed,
the employee's calendar is not changed.
In the same way, if a contract is created directly in `open`
state, the employee's calendar is not changed.
Finally, the calendar synchronization when the employee
contract is changed is only done in payroll, for no reason.

Specification
=============

Fix the three issues described above.

If the employee's calendar is nonetheless manually changed, a warning
should be displayed if there is a mismatch between both calendars.
Before this commit, when we want to make an external url, we need to know
if the record is related to a specific website or not, and choose base_url
or website domain.

Now each model have a fonction get_base_url (public to be callable from email
template, ...) and website override this function to add the website domain if
the record is website specific.

closes odoo#34089

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
…manage the data easy and efficient manner.

   - Also change the keyword report_structure to report_name.
…we increase the quantity. so remove the condition in js to increase the quantity in only fold formate of pdf
-product have a multiple vendor then select the best vendor of it if product have a no best vendor then choose the first vendor of the product
…ile from the 'Bom Structure and cost' report.

-In the component if there is a vendor and vendor cost defined then export the vendor name and vendor cost in the xlsx report
@anr-odoo anr-odoo force-pushed the master-bom-csv-structure-generation-improvement-anr branch from d386881 to 077d8a4 Compare June 17, 2019 10:41
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet