Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 3 #32706

Open
wants to merge 2 commits into
base: 12.0
from

Conversation

Projects
None yet
3 participants
@xabispacebiker
Copy link

xabispacebiker commented Apr 16, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Xabi Spacebiker added some commits Feb 24, 2019

Xabi Spacebiker
Xabi Spacebiker

@robodoo robodoo added the seen 🙂 label Apr 16, 2019

@mart-e

This comment has been minimized.

Copy link
Contributor

mart-e commented Apr 16, 2019

Hello,

Thank you for the CLA signature but it seems there is still an issue.

  • you are signing using the address xabierarrabal@...
  • you are signing for the address xabispacebiker@...

The email address in the CLA must be the same as for the signature for the verification to succeed.
You can either change the your git configuration or modify the email in the CLA signature.

Thanks

@xabispacebiker

This comment has been minimized.

Copy link
Author

xabispacebiker commented Apr 16, 2019

Ok, I have updated my profile in github, please retry

@mart-e

This comment has been minimized.

Copy link
Contributor

mart-e commented Apr 17, 2019

@xabispacebiker the CLA check is not working based on the email set on your profile (which is private) but on the email used for the commit itself.

If you have updated your email in your profile and are using the github web interface to make the commits, you have to make another commit, this one will be with the email you have configured.

You can see which email is used by checking https://github.com/odoo/odoo/pull/32706.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.