Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hw_drivers: Avoid duplicates identifiers in devices #32737

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@qle-odoo
Copy link
Contributor

commented Apr 16, 2019

Before this commit the identifier integrate the BUS and port to identify USB devices
Now we check if there are duplicates devices before increment the identifier

For other loop we add identifier in the iot_device object

task: 1963500

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Apr 16, 2019

@qle-odoo qle-odoo requested a review from sle-odoo Apr 16, 2019

@C3POdoo C3POdoo added the RD label Apr 16, 2019

@qle-odoo qle-odoo force-pushed the odoo-dev:master-iot-duplicate-qle branch from bd012e6 to cfa9da1 Apr 17, 2019

@qle-odoo qle-odoo force-pushed the odoo-dev:master-iot-duplicate-qle branch from cfa9da1 to 45527dd Apr 19, 2019

@qle-odoo qle-odoo requested a review from sle-odoo Apr 19, 2019

@robodoo robodoo added the CI 🤖 label Apr 19, 2019

@sle-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

add task id in commit message, usb_loop docstring should start by the goal of the method, then we're good to go

[FIX] hw_drivers: Avoid duplicates identifiers in devices
Before this commit the identifier integrate the BUS and port to identifiate USB devices
Now we check if there are duplicates devices before increment the identifier

For other loop we add identifier in the iot_device object

task: 1963500

@qle-odoo qle-odoo force-pushed the odoo-dev:master-iot-duplicate-qle branch from 45527dd to af5c433 Apr 23, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.