Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] mrp: allow create component in demo #32772

Closed

Conversation

Projects
None yet
4 participants
@Whenrow
Copy link
Contributor

commented Apr 17, 2019

This commit ticks the 'Create component lot' checkbox for
the demo manufacturing operation type of first warehouse.
This change will leave the default behaviour for all warehouses
but tests with demo data are now more straightforward and do
not demand too much parametrization

Task : 1970450

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Apr 17, 2019

@C3POdoo C3POdoo added the RD label Apr 17, 2019

@robodoo robodoo added the CI 🤖 label Apr 17, 2019

@Whenrow Whenrow force-pushed the odoo-dev:saas-12.3-demo-create-components-whe branch from 2f38098 to b25ec83 Apr 17, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 17, 2019

@Whenrow Whenrow force-pushed the odoo-dev:saas-12.3-demo-create-components-whe branch from b25ec83 to 16ef3c4 Apr 18, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 18, 2019

@Whenrow Whenrow force-pushed the odoo-dev:saas-12.3-demo-create-components-whe branch from 16ef3c4 to 6331012 Apr 18, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 18, 2019

@Whenrow Whenrow force-pushed the odoo-dev:saas-12.3-demo-create-components-whe branch from 6331012 to 89d7fc4 Apr 18, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 18, 2019

Whenrow added some commits Apr 19, 2019

[IMP] mrp: allow create component in demo
This commit ticks the 'Create component lot' checkbox for
the demo manufacturing operation type of first warehouse.
This change will leave the default behaviour for all warehouses
but tests with demo data are now more straightforward and do
not demand too much parametrization

Task : 1970450
[FIX] stock, mrp: handle multi method
Commit 84ae731 used 'self.code' in a method
called by a multi one. As 'self.code' expect a singleton, the transaction
raise an error in case of multiple records into the recordset

This commit calls the method into a loop on 'self and change its signature
to pass 'code' and be sure its a non multi one

@Whenrow Whenrow force-pushed the odoo-dev:saas-12.3-demo-create-components-whe branch from 89d7fc4 to 90dd96d Apr 19, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 19, 2019

@sle-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

robodoo r+ rebase-ff

@robodoo robodoo added the r+ 👌 label Apr 23, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Merge method set to rebase and fast-forward

pniederlag pushed a commit to pniederlag/odoo that referenced this pull request Apr 23, 2019

[IMP] mrp: allow create component in demo
This commit ticks the 'Create component lot' checkbox for
the demo manufacturing operation type of first warehouse.
This change will leave the default behaviour for all warehouses
but tests with demo data are now more straightforward and do
not demand too much parametrization

Task : 1970450

closes odoo#32772

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Apr 23, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 23, 2019

@Whenrow Whenrow deleted the odoo-dev:saas-12.3-demo-create-components-whe branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.