Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] account: generic usability improvements #32775

Conversation

Projects
None yet
4 participants
@william-andre
Copy link
Contributor

commented Apr 17, 2019

Task 1950665

  1. Define a tax on an account should tell if it's a SALE or PURCHASE tax
  2. Credit Note creation from an invoice, label improvement
  3. Improve Payable/Receivable account detection from bank statement reconciliation

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD label Apr 17, 2019

@william-andre william-andre force-pushed the odoo-dev:master-account-generic-usability-wan branch from 0e98e38 to 58421f1 Apr 17, 2019

@robodoo robodoo removed the CI 🤖 label Apr 17, 2019

@william-andre william-andre force-pushed the odoo-dev:master-account-generic-usability-wan branch from 58421f1 to a707e95 Apr 17, 2019

@robodoo robodoo added the CI 🤖 label Apr 17, 2019

@qdp-odoo
Copy link
Contributor

left a comment

just keep name_search() as before, otherwise it's good for me

if type and names['type']:
domain = [connector == '&' and '|' or '&'] + domain + [('type_tax_use', operator, type)]
elif type:
domain = [('type_tax_use', operator, type)]

This comment has been minimized.

Copy link
@qdp-odoo

qdp-odoo Apr 23, 2019

Contributor

keep name_search() as before

This comment has been minimized.

Copy link
@william-andre

william-andre Apr 23, 2019

Author Contributor

done

[IMP] account: generic usability improvements
Task 1950665

1. Define a tax on an account should tell if it's a SALE or PURCHASE tax
2. Credit Note creation from an invoice, label improvement
3. Improve Payable/Receivable account detection from bank statement reconciliation

@william-andre william-andre force-pushed the odoo-dev:master-account-generic-usability-wan branch from a707e95 to 2cf990b Apr 23, 2019

@robodoo robodoo removed the CI 🤖 label Apr 23, 2019

@qdp-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

robodoo pushed a commit that referenced this pull request Apr 23, 2019

[IMP] account: generic usability improvements
Task 1950665

1. Define a tax on an account should tell if it's a SALE or PURCHASE tax
2. Credit Note creation from an invoice, label improvement
3. Improve Payable/Receivable account detection from bank statement reconciliation

closes #32775

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.