Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification system for the frontend #32793

Closed

Conversation

Projects
None yet
2 participants
@qsm-odoo
Copy link
Contributor

commented Apr 18, 2019

No description provided.

@qsm-odoo qsm-odoo self-assigned this Apr 18, 2019

@robodoo robodoo added the seen 🙂 label Apr 18, 2019

@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-frontend-notifications-qsm branch 8 times, most recently from bcd3970 to 7f80813 Apr 18, 2019

@robodoo robodoo added the CI 🤖 label Apr 19, 2019

@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-frontend-notifications-qsm branch from 7f80813 to c8d90fd Apr 24, 2019

@robodoo robodoo removed the CI 🤖 label Apr 24, 2019

[REF] web: reorganize assets_common scripts order
Just reorganize the files by alphabetical order and group them by
folder (core / services / ...) and move the libs on top.

Part of #32793
task-1970731

@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-frontend-notifications-qsm branch from c8d90fd to 5bfbdd6 Apr 24, 2019

qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 24, 2019

[IMP] web, *: share and improve notification system
* calendar, partner_autocomplete

Make the notification system better, using bootstrap toast component,
and make it available in the frontend.

The toast component allowed to remove some JS code and made the
component customizable by themes but it had to be reviewed/fixed to make
it functional (maybe bootstrap will review its work in next versions).

This work should still be improved because there are still too many
ways (deprecated and not deprecated) to instantiate toasts in the
backend. The goal here was however to make the toasts more modern and
make them available in the frontend.

This work is needed for some tasks. @kig-odoo and @fja-odoo made a
pre-work to instantiate toasts in the frontend for their respective
tasks. This commit unifies the system.

Part of odoo#32793
task-1970731

@robodoo robodoo added the CI 🤖 label Apr 24, 2019

@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-frontend-notifications-qsm branch from 5bfbdd6 to 92a4891 Apr 24, 2019

qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 24, 2019

[IMP] web, *: share and improve notification system
* barcodes, calendar, partner_autocomplete, web_settings_dashboard

Make the notification system better, using bootstrap toast component,
and make it available in the frontend.

The toast component allowed to remove some JS code and made the
component customizable by themes but it had to be reviewed/fixed to make
it functional (maybe bootstrap will review its work in next versions).

This work should still be improved because there are still too many
ways (deprecated and not deprecated) to instantiate toasts in the
backend. The goal here was however to make the toasts more modern and
make them available in the frontend.

This work is needed for some tasks. @kig-odoo and @fja-odoo made a
pre-work to instantiate toasts in the frontend for their respective
tasks. This commit unifies the system.

Part of odoo#32793
task-1970731
@qsm-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

@robodoo rebase-ff r+

@robodoo robodoo added r+ 👌 and removed CI 🤖 labels Apr 24, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Merge method set to rebase and fast-forward

@qsm-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

@robodoo robodoo removed the r+ 👌 label Apr 24, 2019

[IMP] web, *: share and improve notification system
* barcodes, calendar, partner_autocomplete, web_settings_dashboard

Make the notification system better, using bootstrap toast component,
and make it available in the frontend.

The toast component allowed to remove some JS code and made the
component customizable by themes but it had to be reviewed/fixed to make
it functional (maybe bootstrap will review its work in next versions).

This work should still be improved because there are still too many
ways (deprecated and not deprecated) to instantiate toasts in the
backend. The goal here was however to make the toasts more modern and
make them available in the frontend.

This work is needed for some tasks. @kig-odoo and @fja-odoo made a
pre-work to instantiate toasts in the frontend for their respective
tasks. This commit unifies the system.

Part of #32793
task-1970731

@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-frontend-notifications-qsm branch from 92a4891 to 1cb94f4 Apr 24, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

robodoo pushed a commit that referenced this pull request Apr 24, 2019

[REF] web: reorganize assets_common scripts order
Just reorganize the files by alphabetical order and group them by
folder (core / services / ...) and move the libs on top.

Part of #32793
task-1970731

robodoo pushed a commit that referenced this pull request Apr 24, 2019

[IMP] web, *: share and improve notification system
* barcodes, calendar, partner_autocomplete, web_settings_dashboard

Make the notification system better, using bootstrap toast component,
and make it available in the frontend.

The toast component allowed to remove some JS code and made the
component customizable by themes but it had to be reviewed/fixed to make
it functional (maybe bootstrap will review its work in next versions).

This work should still be improved because there are still too many
ways (deprecated and not deprecated) to instantiate toasts in the
backend. The goal here was however to make the toasts more modern and
make them available in the frontend.

This work is needed for some tasks. @kig-odoo and @fja-odoo made a
pre-work to instantiate toasts in the frontend for their respective
tasks. This commit unifies the system.

Part of #32793
task-1970731

closes #32793

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

fja-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 24, 2019

[REF] web: reorganize assets_common scripts order
Just reorganize the files by alphabetical order and group them by
folder (core / services / ...) and move the libs on top.

Part of odoo#32793
task-1970731

fja-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 24, 2019

[IMP] web, *: share and improve notification system
* barcodes, calendar, partner_autocomplete, web_settings_dashboard

Make the notification system better, using bootstrap toast component,
and make it available in the frontend.

The toast component allowed to remove some JS code and made the
component customizable by themes but it had to be reviewed/fixed to make
it functional (maybe bootstrap will review its work in next versions).

This work should still be improved because there are still too many
ways (deprecated and not deprecated) to instantiate toasts in the
backend. The goal here was however to make the toasts more modern and
make them available in the frontend.

This work is needed for some tasks. @kig-odoo and @fja-odoo made a
pre-work to instantiate toasts in the frontend for their respective
tasks. This commit unifies the system.

Part of odoo#32793
task-1970731

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Apr 24, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 24, 2019

@qsm-odoo qsm-odoo deleted the odoo-dev:master-frontend-notifications-qsm branch Apr 24, 2019

fja-odoo added a commit to odoo-dev/odoo that referenced this pull request May 10, 2019

[FIX] web: restore notifications about disconnections
The disconnected/connected notifications were broken due to changes in
the way the Notification template was loaded. We need it loaded in
assets as we cannot load it afterward if the server is disconnected.

This was broken by : odoo#32793

fja-odoo added a commit to odoo-dev/odoo that referenced this pull request May 13, 2019

[FIX] web: restore notifications about disconnections
The disconnected/connected notifications were broken due to changes in
the way the Notification template was loaded. We need it loaded in
assets as we cannot load it afterward if the server is disconnected.

This was broken by : odoo#32793

fja-odoo added a commit to odoo-dev/odoo that referenced this pull request May 14, 2019

[FIX] web: restore notifications about disconnections
The disconnected/connected notifications were broken due to changes in
the way the Notification template was loaded. We need it loaded in
assets as we cannot load it afterward if the server is disconnected.

This was broken by : odoo#32793

robodoo pushed a commit that referenced this pull request May 15, 2019

[FIX] web: restore notifications about disconnections
The disconnected/connected notifications were broken due to changes in
the way the Notification template was loaded. We need it loaded in
assets as we cannot load it afterward if the server is disconnected.

This was broken by : #32793

closes #33252

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.