Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: update buttons in editable list #32817

Open
wants to merge 1 commit into
base: saas-12.1
from

Conversation

Projects
None yet
6 participants
@pka-odoo
Copy link
Contributor

commented Apr 19, 2019

  • In an editable view when editing a row, then apply or remove any groupby or filter.The control panel buttons are not updated. So, save and discard buttons are always displaying.

  • This issue occurs because when applying or removing filters, 'o-editing' class is removed. But in our case view mode does not change to readonly so it not updating the editing class.

  • so, update buttons by setting the view mode to readonly.

Description of the issue/feature this PR addresses:
when grouping is done, an editable row should unselect so Save and Discard button issue never raised.

Current behavior before PR:
after applying or removing a filter, save and discard button does not update to create button

Desired behavior after PR is merged:
the Save / Discard buttons switch back to the Create button when a group by is applied

Issue:
https://www.odoo.com/web#id=1967278&action=327&model=project.task&view_type=form&menu_id=4720

Pad:
https://pad.odoo.com/p/r.181fd3430c89eccf001f5ebc4d4eee09

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Apr 19, 2019

@C3POdoo C3POdoo added the RD label Apr 19, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 19, 2019

@msh-odoo msh-odoo force-pushed the odoo-dev:saas-12.1-web-editable-list-update-buttons-pka branch from aeb11f8 to 643e479 Apr 24, 2019

@robodoo robodoo added the CI 🤖 label Apr 24, 2019

@pka-odoo pka-odoo force-pushed the odoo-dev:saas-12.1-web-editable-list-update-buttons-pka branch from 643e479 to 598095a Apr 29, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 29, 2019

@pka-odoo pka-odoo force-pushed the odoo-dev:saas-12.1-web-editable-list-update-buttons-pka branch from 598095a to 2d835ff Apr 30, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 30, 2019

@pedrobaeza

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

Is it possible to fix this in 11.0?

@sswapnesh

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

Is it possible to fix this in 11.0?

and also in v12 ? (PR is for 12.1)

@VincentSchippefilt

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

#33572 will fix this in 11.0.

@VincentSchippefilt VincentSchippefilt force-pushed the odoo-dev:saas-12.1-web-editable-list-update-buttons-pka branch from 2d835ff to b042d72 May 23, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 23, 2019

@VincentSchippefilt VincentSchippefilt force-pushed the odoo-dev:saas-12.1-web-editable-list-update-buttons-pka branch from b042d72 to cd74495 May 23, 2019

@robodoo robodoo removed the CI 🤖 label May 23, 2019

[FIX] web: add test for the fix update buttons in editable list
The test for the fix in 5adb6b6 can only be implemented in 12.1
because that is the version that contains the createActionManager helper

Task-1967278

@VincentSchippefilt VincentSchippefilt force-pushed the odoo-dev:saas-12.1-web-editable-list-update-buttons-pka branch from cd74495 to 70abba8 May 23, 2019

@robodoo robodoo added the CI 🤖 label May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.