Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master universal uom jem #32840

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@jem-odoo
Copy link
Contributor

commented Apr 19, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Apr 19, 2019

@C3POdoo C3POdoo added the RD label Apr 19, 2019

@jem-odoo jem-odoo force-pushed the odoo-dev:master-universal-uom-jem branch from c84ee95 to 34125cd Apr 24, 2019

@robodoo robodoo added the CI 🤖 label Apr 24, 2019

Show resolved Hide resolved addons/uom/data/uom_data.xml Outdated

@jem-odoo jem-odoo force-pushed the odoo-dev:master-universal-uom-jem branch from 34125cd to 7f342f8 May 13, 2019

@robodoo robodoo removed the CI 🤖 label May 13, 2019

@jem-odoo jem-odoo force-pushed the odoo-dev:master-universal-uom-jem branch from 7f342f8 to 1a180a3 May 13, 2019

@jem-odoo

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

As @dbo-odoo is ok with that, let's merge this !
@robodoo rebase-ff r+

Feyensv and others added some commits Apr 10, 2019

[IMP] uom: rename measurement type 'time' into 'working_time'
This commit rename the measrurement_type 'time' into
'working_time' to be more precise, as time might means
duration.
This changes prepare the distinction between 'working time'
and international duration unit.

Task-1971491
[IMP] uom: introduces duration unit of measure
This commit introduces the duration (time) units of measures, flagged as internation
unit of measure. We already have the "working time" UoM, but those ones are customizable
and might differ from the International System of Units; indeed, one working day means
8 hours (more or less) for some company.
The rational here is, when we are handling datetime, we need to get the UoM in the Odoo
System to convert the result; for instance, computing the difference between 2 datetimes
will return the number of days (or hours). But you need to match it with an odoo UoM to
extract informations from that value.

This unit of measure 'duration' is like a master data, because existing in the real world
and that many module will depend on.

Task-1971491

@jem-odoo jem-odoo force-pushed the odoo-dev:master-universal-uom-jem branch from 1a180a3 to 92df16a May 14, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Merge method set to rebase and fast-forward

@robodoo robodoo added the CI 🤖 label May 14, 2019

@jem-odoo

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@robodoo robodoo added the r+ 👌 label May 14, 2019

robodoo pushed a commit that referenced this pull request May 14, 2019

[IMP] uom: introduces duration unit of measure
This commit introduces the duration (time) units of measures, flagged as internation
unit of measure. We already have the "working time" UoM, but those ones are customizable
and might differ from the International System of Units; indeed, one working day means
8 hours (more or less) for some company.
The rational here is, when we are handling datetime, we need to get the UoM in the Odoo
System to convert the result; for instance, computing the difference between 2 datetimes
will return the number of days (or hours). But you need to match it with an odoo UoM to
extract informations from that value.

This unit of measure 'duration' is like a master data, because existing in the real world
and that many module will depend on.

Task-1971491

closes #32840

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Merged, thanks!

@robodoo robodoo closed this May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.