Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] base: use correct iso code for Filipino #32867

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@mart-e
Copy link
Contributor

commented Apr 23, 2019

Instead of fil - fil_PH, it should have been fil_PH - fil.

The iso_code is used in URLs

The "code" value can not be changed in stable but iso-code can.
The code value will be changed in master as requires a migration script

[FIX] base: use correct iso code for Filipino
Instead of fil - fil_PH, it should have been fil_PH - fil.

The iso_code is used in URLs

The "code" value can not be changed in stable but iso-code can.
The code value will be changed in master as requires a migration script

@mart-e mart-e requested a review from julienlegros Apr 23, 2019

@robodoo robodoo added the seen 🙂 label Apr 23, 2019

mart-e added a commit to odoo-dev/odoo that referenced this pull request Apr 23, 2019

[FIX] base: use correct code for Filipino
Master version of odoo#32867
Instead of fil - fil_PH, it should have been fil_PH - fil.

@C3POdoo C3POdoo added the RD label Apr 23, 2019

@pedrobaeza

This comment has been minimized.

Copy link
Collaborator

commented Apr 23, 2019

This will make current installations to fail with the constraint of not able to change the code.

@robodoo robodoo added the CI 🤖 label Apr 23, 2019

@mart-e

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@pedrobaeza this is why I made a small PR in 12.0 and the full change in master at #32868

@pedrobaeza

This comment has been minimized.

Copy link
Collaborator

commented Apr 23, 2019

Ah, OK, sorry for the noise.

@mart-e

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 26, 2019

[FIX] base: use correct code for Filipino
Master version of #32867
Instead of fil - fil_PH, it should have been fil_PH - fil.

closes #32868

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

@robodoo robodoo closed this in c991315 Apr 26, 2019

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Apr 26, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

Merged, thanks!

@mart-e mart-e deleted the odoo-dev:12.0-fil-iso-code-mat branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.