Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assertRecordValues ouput for tests in common.py #32869

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Goaman
Copy link
Contributor

commented Apr 23, 2019

Before this commit, when assertRecordValues output errors,
it was hard to quickly see where the change were located.

This commit add a summary of the difference between the two value
being compared. It also add colors to the output in order to
improve the readability.

In short, it looks like:
https://imgur.com/HnEPx3T

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Apr 23, 2019

@C3POdoo C3POdoo added the RD label Apr 23, 2019

@Goaman Goaman requested a review from smetl Apr 24, 2019

@Goaman Goaman force-pushed the odoo-dev:master-improve-assertRecordValues-output-nby branch 3 times, most recently from 555b66e to 45513e9 Apr 25, 2019

@robodoo robodoo added the CI 🤖 label Apr 25, 2019

Improve assertRecordValues ouput for tests in common.py
Before this commit, when assertRecordValues output errors, it was
hard to quickly see where the change were located. This commit add
a summary of the difference between the two value being compared.

It also add colors to the output in order to improve the readability.

@Goaman Goaman force-pushed the odoo-dev:master-improve-assertRecordValues-output-nby branch from 45513e9 to 138d4c1 Apr 26, 2019

@robodoo robodoo removed the CI 🤖 label Apr 26, 2019

@Goaman Goaman force-pushed the odoo-dev:master-improve-assertRecordValues-output-nby branch from 138d4c1 to 0841679 Apr 26, 2019

@Goaman

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@rco-odoo Can you check this PR when you have time? :)

@Goaman Goaman requested a review from rco-odoo Apr 26, 2019

@robodoo robodoo added the CI 🤖 label Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.