Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] models: new implementation of prefetching #32905

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
5 participants
@rco-odoo
Copy link
Member

commented Apr 24, 2019

Records come with a simpler data structure for prefetching, namely record._prefetch_ids, which is an iterable of record ids to prefetch.

@robodoo robodoo added the seen 🙂 label Apr 24, 2019

@C3POdoo C3POdoo added the RD label Apr 24, 2019

@rco-odoo rco-odoo requested a review from odony Apr 24, 2019

@robodoo robodoo added the CI 🤖 label Apr 24, 2019

@odony

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Would be interesting to check the result of this test script after this patch too.

@odony

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@xmo-odoo Do you think you could verify the use case from #31804 and maybe revert that with_prefetch() if unnecessary after this PR?

@rco-odoo rco-odoo force-pushed the odoo-dev:master-simplify-prefetch-rco branch Apr 30, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 30, 2019

@xmo-odoo

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

@odony can probably be removed as part of the PR. I don't have the exact original repro case anymore, but installing the relevant-ish modules (contacts & base address extended), importing 1000 partners with partner_id set (all to the same parent) takes about the same time to import with or without the with_prefetch() on my machine (~1:35, ~35s SQL, ~60s Python, and 47040 queries).

@rco-odoo rco-odoo force-pushed the odoo-dev:master-simplify-prefetch-rco branch Apr 30, 2019

@robodoo robodoo removed the CI 🤖 label Apr 30, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-simplify-prefetch-rco branch 2 times, most recently Apr 30, 2019

@robodoo robodoo added the CI 🤖 label Apr 30, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-simplify-prefetch-rco branch May 2, 2019

@robodoo robodoo removed the CI 🤖 label May 2, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-simplify-prefetch-rco branch May 2, 2019

@robodoo robodoo added the CI 🤖 label May 2, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-simplify-prefetch-rco branch May 2, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-simplify-prefetch-rco branch May 6, 2019

@robodoo robodoo removed the CI 🤖 label May 6, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-simplify-prefetch-rco branch to c80d03e May 6, 2019

@robodoo robodoo added the CI 🤖 label May 6, 2019

@rco-odoo

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

@robodoo rebase-ff r+

@robodoo robodoo added the r+ 👌 label May 6, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

Merge method set to rebase and fast-forward

@robodoo

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

Linked pull request(s) odoo/enterprise#4235 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request May 6, 2019

[FIX] test_mail: adapt query counts
closes #32905

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

@robodoo robodoo added the merging 👷 label May 6, 2019

robodoo pushed a commit that referenced this pull request May 8, 2019

[FIX] test_mail: adapt query counts
closes #32905

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

@robodoo robodoo added merged 🎉 and removed merging 👷 labels May 8, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Merged, thanks!

@robodoo robodoo closed this May 8, 2019

@rco-odoo rco-odoo deleted the odoo-dev:master-simplify-prefetch-rco branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.