Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website: restore facebook snippet #32921

Closed

Conversation

Projects
None yet
4 participants
@kig-odoo
Copy link
Contributor

commented Apr 24, 2019

  • facebook snippet must be instantiated in edit mode

@robodoo robodoo added the CI 🤖 label Apr 24, 2019

@kig-odoo kig-odoo force-pushed the odoo-dev:saas-12.3-website-snippet-fix-kig branch from 8bd0bbb to 51de17f Apr 24, 2019

kig-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 24, 2019

[FIX] website: restore facebook snippet
- facebook snippet must be instantiated in edit mode
- facebook API not accepting float values anymore for height and width parameter

closes odoo#32921

@robodoo robodoo removed the CI 🤖 label Apr 24, 2019

@kig-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

Hello @qsm-odoo ,

Here is the PR for the facebook snippet issue that we discussed.

Thanks

@C3POdoo C3POdoo added the RD label Apr 24, 2019

@robodoo robodoo added the CI 🤖 label Apr 24, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

@kig-odoo About the floating values, is not this a fix for the version where the facebook snippet was introduced ? Thanks

@kig-odoo kig-odoo force-pushed the odoo-dev:saas-12.3-website-snippet-fix-kig branch from 51de17f to 5574c2d Apr 26, 2019

kig-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 26, 2019

[FIX] website: restore facebook snippet
- facebook snippet must be instantiated in edit mode

closes odoo#32921

@robodoo robodoo removed the CI 🤖 label Apr 26, 2019

@kig-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@qsm-odoo
You're right it should be fixed in 12.0.
I've created another PR for that see: #32970

Thanks :)

@robodoo robodoo added the CI 🤖 label Apr 26, 2019

[FIX] website: restore Facebook snippets in edit mode
Facebook snippets' related widgets must be instantiated in edit mode.

This was broken when the feature which disables the widgets in edit mode
by default was introduced with 335a505.

@qsm-odoo qsm-odoo force-pushed the odoo-dev:saas-12.3-website-snippet-fix-kig branch from 5574c2d to 269ced6 Apr 29, 2019

@robodoo robodoo removed the CI 🤖 label Apr 29, 2019

@qsm-odoo
Copy link
Contributor

left a comment

@robodoo r+

(Reviewed the commit message)

robodoo pushed a commit that referenced this pull request Apr 29, 2019

[FIX] website: restore Facebook snippets in edit mode
Facebook snippets' related widgets must be instantiated in edit mode.

This was broken when the feature which disables the widgets in edit mode
by default was introduced with 335a505.

closes #32921

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Apr 29, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 29, 2019

@qsm-odoo qsm-odoo deleted the odoo-dev:saas-12.3-website-snippet-fix-kig branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.