Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] website: restore facebook snippet #32921

Closed
wants to merge 1 commit into from
Closed

[FIX] website: restore facebook snippet #32921

wants to merge 1 commit into from

Conversation

kig-odoo
Copy link
Contributor

@kig-odoo kig-odoo commented Apr 24, 2019 •
edited

  • facebook snippet must be instantiated in edit mode

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 24, 2019
@kig-odoo kig-odoo force-pushed the saas-12.3-website-snippet-fix-kig branch from 8bd0bbb to 51de17f Compare April 24, 2019 13:28
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 24, 2019
@kig-odoo
Copy link
Contributor Author

Hello @qsm-odoo ,

Here is the PR for the facebook snippet issue that we discussed.

Thanks

@C3POdoo C3POdoo added the RD research & development, internal work label Apr 24, 2019
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 24, 2019
@qsm-odoo
Copy link
Contributor

@kig-odoo About the floating values, is not this a fix for the version where the facebook snippet was introduced ? Thanks

@kig-odoo kig-odoo force-pushed the saas-12.3-website-snippet-fix-kig branch from 51de17f to 5574c2d Compare April 26, 2019 05:14
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 26, 2019
@kig-odoo
Copy link
Contributor Author

@qsm-odoo
You're right it should be fixed in 12.0.
I've created another PR for that see: #32970

Thanks :)

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Apr 26, 2019
@kig-odoo @qsm-odoo
[FIX] website: restore Facebook snippets in edit mode
269ced6 
Facebook snippets' related widgets must be instantiated in edit mode.

This was broken when the feature which disables the widgets in edit mode
by default was introduced with odoo@335a505.
@qsm-odoo qsm-odoo force-pushed the saas-12.3-website-snippet-fix-kig branch from 5574c2d to 269ced6 Compare April 29, 2019 10:23
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Apr 29, 2019
qsm-odoo
qsm-odoo approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@qsm-odoo qsm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

(Reviewed the commit message)

@robodoo robodoo added r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Apr 29, 2019
robodoo pushed a commit that referenced this pull request Apr 29, 2019
@kig-odoo @qsm-odoo
[FIX] website: restore Facebook snippets in edit mode
8e7a9b5 
Facebook snippets' related widgets must be instantiated in edit mode.

This was broken when the feature which disables the widgets in edit mode
by default was introduced with 335a505.

closes #32921

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo
Copy link
Contributor

robodoo commented Apr 29, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 29, 2019
@qsm-odoo qsm-odoo deleted the saas-12.3-website-snippet-fix-kig branch April 29, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qsm-odoo qsm-odoo qsm-odoo approved these changes

Assignees
No one assigned
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kig-odoo @qsm-odoo @robodoo @C3POdoo