Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] models: use new records only in onchange #32930

Open
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@rco-odoo
Copy link
Member

commented Apr 24, 2019

Using new records in onchange() simplifies code: the environment flag in_onchange is gone, and all special cases correspond to new records. The expression record._origin is now available on all records, and returns the actual record corresponding to record.

@robodoo robodoo added the seen 🙂 label Apr 24, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-onchange-new-rco branch 2 times, most recently from eeb1ae0 to c690e82 Apr 24, 2019

@C3POdoo C3POdoo added the RD label Apr 24, 2019

Show resolved Hide resolved odoo/fields.py Outdated

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 26, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-onchange-new-rco branch 2 times, most recently from 6892132 to e294489 Apr 29, 2019

Show resolved Hide resolved odoo/fields.py Outdated
Show resolved Hide resolved odoo/fields.py
Show resolved Hide resolved odoo/fields.py
Show resolved Hide resolved odoo/models.py Outdated
Show resolved Hide resolved odoo/models.py Outdated
Show resolved Hide resolved odoo/fields.py Outdated

@rco-odoo rco-odoo force-pushed the odoo-dev:master-onchange-new-rco branch 3 times, most recently from 27d67b4 to 0b9a59b May 6, 2019

@robodoo robodoo added the CI 🤖 label May 10, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-onchange-new-rco branch from 56e592c to 7182fa3 May 10, 2019

@robodoo robodoo removed the CI 🤖 label May 10, 2019

@celm1990

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

@rco-odoo this commit must be solve issue #21510 and #21511 ???

@rco-odoo rco-odoo force-pushed the odoo-dev:master-onchange-new-rco branch from d8cfb31 to ab994b7 May 10, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 10, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-onchange-new-rco branch from 45b4f04 to 0f2926f May 13, 2019

@robodoo robodoo removed the CI 🤖 label May 13, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 15, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-onchange-new-rco branch from 1c349b4 to 6a08575 May 16, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 16, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-onchange-new-rco branch from 6a08575 to 2c1fea9 May 20, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 20, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-onchange-new-rco branch from 2c1fea9 to 1d973ad May 21, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 21, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-onchange-new-rco branch 2 times, most recently from 35439a5 to 385c6cf May 21, 2019

@robodoo robodoo added the CI 🤖 label May 21, 2019

@rco-odoo rco-odoo force-pushed the odoo-dev:master-onchange-new-rco branch from 385c6cf to 61d1e3e May 22, 2019

@robodoo robodoo removed the CI 🤖 label May 22, 2019

@@ -111,7 +111,7 @@ def _add_hdd_attribute_line(self):
self.computer_hdd_attribute_lines.product_template_value_ids[2].price_extra = 8

def _add_ram_exclude_for(self):
self._get_product_value_id(self.computer_ram_attribute_lines, self.ram_16).update({
self._get_product_value_id(self.computer_ram_attribute_lines, self.ram_16).write({

This comment has been minimized.

Copy link
@rco-odoo

rco-odoo May 22, 2019

Author Member

necessary?

@robodoo robodoo added the CI 🤖 label May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.