Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] sale_timesheet: Project overview with downpayment #32962

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@simongoffin
Copy link
Contributor

commented Apr 25, 2019

[FIX] sale_timesheet: Project overview with downpayment

Steps to reproduce the bug:
- Install Timesheet, Sales, Accounting
- Create a product P that creates a project when validated on a SO
- Create a SO with P and validate it
- Create an invoice with a downpayment of 10% and validate it
- On the SO, click on "Overview" button

Bug:

The invoiced amount  on the overview was not updated with the downpayment invoiced.
When the SO was completely invoiced, the amount of the downpayment was counted in
"Other cost" (because an analityc line is created for the downpayment SO line)

opw:1969143

@robodoo robodoo added the seen 🙂 label Apr 25, 2019

@C3POdoo C3POdoo added the OE label Apr 25, 2019

@robodoo robodoo added the CI 🤖 label Apr 25, 2019

@simongoffin simongoffin force-pushed the odoo-dev:12.0-opw-1969143-fix-sig branch from 871fd7e to 36fd47f Apr 29, 2019

@robodoo robodoo removed the CI 🤖 label Apr 29, 2019

@simongoffin simongoffin force-pushed the odoo-dev:12.0-opw-1969143-fix-sig branch from 36fd47f to cd54092 Apr 29, 2019

@robodoo robodoo added the CI 🤖 label Apr 29, 2019

@simongoffin simongoffin force-pushed the odoo-dev:12.0-opw-1969143-fix-sig branch from cd54092 to c81b859 Apr 29, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Apr 29, 2019

@simongoffin simongoffin changed the title [FIX] sale_timesheet: [FIX] sale_timesheet: Project overview with downpayment Apr 30, 2019

[FIX] sale_timesheet: Project(s) overview wrong with downpayment
Steps to reproduce the bug:
- Install Timesheet, Sales, Accounting
- Create a product P that creates a project when validated on a SO
- Create a SO with P and validate it
- Create an invoice with a downpayment of 10% and validate it
- On the SO, click on "Project(s) overview" smart button

Bug:

The invoiced amount  on the overview was not updated with the downpayment invoiced.
When the SO was completely invoiced, the amount of the downpayment was counted in
"Other cost" (because an analityc line is created for the downpayment SO line)

opw:1969143

@simongoffin simongoffin force-pushed the odoo-dev:12.0-opw-1969143-fix-sig branch from c81b859 to fdacf4b Apr 30, 2019

@robodoo robodoo removed the CI 🤖 label Apr 30, 2019

@simongoffin

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 30, 2019

[FIX] sale_timesheet: Project(s) overview wrong with downpayment
Steps to reproduce the bug:
- Install Timesheet, Sales, Accounting
- Create a product P that creates a project when validated on a SO
- Create a SO with P and validate it
- Create an invoice with a downpayment of 10% and validate it
- On the SO, click on "Project(s) overview" smart button

Bug:

The invoiced amount  on the overview was not updated with the downpayment invoiced.
When the SO was completely invoiced, the amount of the downpayment was counted in
"Other cost" (because an analityc line is created for the downpayment SO line)

opw:1969143

closes #32962

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Merged, thanks!

@robodoo robodoo closed this Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.