Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website: restore facebook snippet #32970

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@kig-odoo
Copy link
Contributor

commented Apr 26, 2019

  • facebook API not accepting float values anymore for height and width parameter

@robodoo robodoo added the seen 🙂 label Apr 26, 2019

@kig-odoo kig-odoo force-pushed the odoo-dev:12.0-website-snippet-fix-kig branch from 19d320b to 049da76 Apr 26, 2019

kig-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 26, 2019

[FIX] website: restore facebook snippet
- facebook API not accepting float values anymore for height and width parameter

closes odoo#32970

@C3POdoo C3POdoo added the RD label Apr 26, 2019

@robodoo robodoo added the CI 🤖 label Apr 26, 2019

@qsm-odoo qsm-odoo force-pushed the odoo-dev:12.0-website-snippet-fix-kig branch from 049da76 to b0cab0d Apr 29, 2019

@robodoo robodoo removed the CI 🤖 label Apr 29, 2019

[FIX] website: adapt Facebook snippet to API changes
Facebook API does not accept float values for height and width
parameters anymore.

@qsm-odoo qsm-odoo force-pushed the odoo-dev:12.0-website-snippet-fix-kig branch from b0cab0d to 70cf2d7 Apr 29, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@kig-odoo I reviewed your commit message and changed parseInt with Math.floor, I think it is more explicit unless you see a problem with it ? (https://github.com/odoo/odoo/compare/b0cab0d39fab77e683951b8965b612cf4555eafe..70cf2d7100fec6ae5186cf0885de7cd688debff6)

@kig-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@qsm-odoo it's ok to use Math.floor 👍

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Merged, thanks!

@qsm-odoo qsm-odoo deleted the odoo-dev:12.0-website-snippet-fix-kig branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.