Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: mark as read triggers notification #33363

Conversation

Projects
None yet
4 participants
@Julien00859
Copy link
Member

commented May 14, 2019

Install discuss, change the general setting in dev mode to disable the
"Show Effect" checkbox. Change the preferences of the user to let odoo
handle notifications. Ask another user to ping you on a chatter then go
to discuss and click the "Mark as Read" button. Traceback.

The notification_manager field does not exists. This fix corrects the
code by using the notification agent.

opw-1986844

@Julien00859 Julien00859 requested a review from nim-odoo May 14, 2019

@Julien00859

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

Original commit is 1a7815f

@robodoo robodoo added the seen 🙂 label May 14, 2019

@nim-odoo nim-odoo requested review from nle-odoo and removed request for nim-odoo May 14, 2019

@nle-odoo
Copy link
Contributor

left a comment

ok, maybe say in commit message "does not exist since 07cd24b"

robodoo delegate+

@robodoo robodoo added the CI 🤖 label May 14, 2019

@C3POdoo C3POdoo added the OE label May 14, 2019

[FIX] web: mark as read trigger notification
Install discuss, change the general setting in dev mode to disable the
"Show Effect" checkbox. Change the preferences of the user to let odoo
handle notifications. Ask another user to ping you on a chatter then go
to discuss and click the "Mark as Read" button. Traceback.

The `notification_manager` agent has been replaced by another agent in
07cd24b, the code has been updated to use the new agent.

opw-1986844

@Julien00859 Julien00859 force-pushed the odoo-dev:12.0-opw-1986844-mark_as_read_effect-juc branch from 928f7c9 to 878b7c1 May 15, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 15, 2019

@Julien00859

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

robodoo r+

@robodoo

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.