Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] product_configurator #33371

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@Feyensv
Copy link

commented May 14, 2019

Move a base p_configurator inside sale allowing for hooks on product_product or product_template.
Refactor product_configurator and event_configurator.
Remove event_sale_product_configurator bridge module.

Flows :
Line creation : product (or template if sale_product_configurator installed) then:
1* If variants && product_configurator : product configurator defines the product_id based on the template
* If optional products are defined: choose them through the configurator (and step 2 not supported)
2* If product is configurable (event), event configurator opens.

Improvement: support variants on event registrations (but not optional products) (or don't allow it like #32385).

Task ID: 1997726

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label May 14, 2019

@C3POdoo C3POdoo added the RD label May 14, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-p-configurator-vfe branch 4 times, most recently from 2306e39 to 99188b5 May 15, 2019

@robodoo robodoo added the CI 🤖 label May 15, 2019

@Feyensv Feyensv requested a review from awa-odoo May 15, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-p-configurator-vfe branch from 99188b5 to ced0d21 May 15, 2019

@robodoo robodoo removed the CI 🤖 label May 15, 2019

@awa-odoo

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@Feyensv I like where this is going but I see it's still WIP.
Can I test and review this yet or are you still working on it?

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 15, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-p-configurator-vfe branch from 089653d to f4b22b2 May 16, 2019

@robodoo robodoo added the CI 🤖 label May 16, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-p-configurator-vfe branch from f4b22b2 to c54b2c0 May 16, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 16, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-p-configurator-vfe branch from c54b2c0 to 420fccb May 17, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 17, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-p-configurator-vfe branch from 420fccb to b5c28ac May 20, 2019

@robodoo robodoo removed the CI 🤖 label May 20, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-p-configurator-vfe branch from b5c28ac to 338ad9b May 21, 2019

@robodoo robodoo added the CI 🤖 label May 21, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-p-configurator-vfe branch from 338ad9b to e86f8f6 May 22, 2019

@robodoo robodoo removed the CI 🤖 label May 22, 2019

@Feyensv Feyensv force-pushed the odoo-dev:master-p-configurator-vfe branch 2 times, most recently from 511eff1 to 3031d99 May 22, 2019

@robodoo robodoo added the CI 🤖 label May 22, 2019

[REF] product_configurator
Allow easier extension for future apps/modules
Fix tests for those extensions

@Feyensv Feyensv force-pushed the odoo-dev:master-p-configurator-vfe branch from 3031d99 to a7dd95b May 22, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels May 22, 2019

@Feyensv

This comment has been minimized.

Copy link
Author

commented May 22, 2019

@awa-odoo ready for review :).
Two things to note:

  • event configuration doesn't work in combination with optional products (if optional products are chosen, the event configurator opens but its changes aren't applied to so line).
  • When a ticket registration has variants, after creation of the so line, the edit wizard only reopens the event wizard (not the product_configurator anymore). I don't find problematic to not be able to reconfigure the product variants of a defined ticket, but it is still a limitation to know.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.