Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] expense track values: #33909

Open
wants to merge 2 commits into
base: master
from

Conversation

@MaxLarue
Copy link
Contributor

commented Jun 5, 2019

At the moment, no changes applied to an expense/expense-report is mentioned in its chatter. It is interesting to indicate the most important changes, as expenses can be quite a sensitive subject in some cases.

Thus we are adding the tracking argument to the following fields:

hr.expense:
-name
-total_amount
-payment_mode
-employee_id
-sale_order_id

hr.expense.sheet
-name
-employee_id
-payment_mode
-total_amount

task 1978580

Description of the issue/feature this PR addresses:
Tracking some values of expense and expense report in the chatter

Current behavior before PR:
Nothing is said in the chatter when a value change

Desired behavior after PR is merged:
There is an entry in the chatter every time one of the values change

task 1978580

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the CI 🤖 label Jun 5, 2019
@C3POdoo C3POdoo added the RD label Jun 5, 2019
@MaxLarue MaxLarue force-pushed the odoo-dev:master-expense-track-changes-mla branch Jun 14, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jun 14, 2019
@MaxLarue MaxLarue force-pushed the odoo-dev:master-expense-track-changes-mla branch to f3e0da5 Jun 25, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jun 25, 2019
@MaxLarue MaxLarue force-pushed the odoo-dev:master-expense-track-changes-mla branch from f3e0da5 to 0d02f1c Aug 21, 2019
@robodoo robodoo removed the CI 🤖 label Aug 21, 2019
@MaxLarue MaxLarue force-pushed the odoo-dev:master-expense-track-changes-mla branch 2 times, most recently from 1b946ba to 041d432 Aug 22, 2019
@robodoo robodoo added the CI 🤖 label Aug 22, 2019
grep Outdated
@@ -0,0 +1 @@
printp available

This comment has been minimized.

Copy link
@mart-e

mart-e Aug 22, 2019

Contributor

probably not intentional

@MaxLarue MaxLarue force-pushed the odoo-dev:master-expense-track-changes-mla branch from 041d432 to 7bd9d69 Aug 22, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Aug 22, 2019
@MaxLarue MaxLarue force-pushed the odoo-dev:master-expense-track-changes-mla branch from 7bd9d69 to 175a999 Oct 9, 2019
@robodoo robodoo added seen 🙂 CI 🤖 and removed CI 🤖 labels Oct 9, 2019
@MaxLarue MaxLarue force-pushed the odoo-dev:master-expense-track-changes-mla branch from 175a999 to 86cbd61 Oct 9, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 9, 2019
@MaxLarue MaxLarue force-pushed the odoo-dev:master-expense-track-changes-mla branch from 86cbd61 to 6801aac Oct 10, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 10, 2019
@MaxLarue MaxLarue force-pushed the odoo-dev:master-expense-track-changes-mla branch from 6801aac to a7aac43 Oct 10, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 10, 2019
MaxLarue added 2 commits Jun 5, 2019
At the moment, no changes applied to an expense/expense-report is mentioned in its chatter. It is interesting to indicate the most important changes, as expenses can be quite a sensitive subject in some cases.

Thus we are adding the tracking argument to the following fields:

hr.expense:
	-name
	-total_amount
	-payment_mode
	-employee_id

hr.expense.sheet
	-name
	-employee_id
	-payment_mode
	-total_amount

task 1978580
Since we change the expense sheet to an editable tree view, we had to add some fields on it since it doesn't open a form view anymore.
We take advantage of the optional fields on tree views to allow the user to remove some of those fields if they are not needed.

Task-1978580
@MaxLarue MaxLarue force-pushed the odoo-dev:master-expense-track-changes-mla branch from a7aac43 to c6a8a24 Oct 14, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.