Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master social app awa #34973

Closed
wants to merge 5 commits into from

Conversation

@awa-odoo
Copy link
Contributor

commented Jul 18, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the CI 🤖 label Jul 18, 2019
@C3POdoo C3POdoo added the RD label Jul 18, 2019
@@ -43,3 +43,4 @@ XlsxWriter==0.9.3
xlwt==1.3.*
xlrd==1.0.0
pypiwin32 ; sys_platform == 'win32'
firebase-admin==2.17.0

This comment has been minimized.

Copy link
@mreficent

mreficent Jul 18, 2019

Contributor

@d-fence , to fill the other requirement files

This comment has been minimized.

Copy link
@awa-odoo

awa-odoo Jul 18, 2019

Author Contributor

@mreficent It's already being taken care of, thanks

@awa-odoo awa-odoo force-pushed the odoo-dev:master-social-app-awa branch from f749fe9 to 4e0d856 Aug 7, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Aug 7, 2019
@awa-odoo awa-odoo force-pushed the odoo-dev:master-social-app-awa branch from 4e0d856 to b5d2178 Aug 7, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Aug 7, 2019
@awa-odoo awa-odoo force-pushed the odoo-dev:master-social-app-awa branch from b5d2178 to b53c834 Aug 19, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Aug 19, 2019
@awa-odoo awa-odoo force-pushed the odoo-dev:master-social-app-awa branch from b53c834 to 388d044 Aug 22, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Aug 22, 2019
@awa-odoo awa-odoo force-pushed the odoo-dev:master-social-app-awa branch from 388d044 to 84f02a5 Sep 3, 2019
@robodoo robodoo added seen 🙂 and removed CI 🤖 labels Sep 3, 2019
@awa-odoo awa-odoo changed the base branch from master to saas-12.5 Sep 3, 2019
@robodoo robodoo added the CI 🤖 label Sep 3, 2019
dbeguin added a commit to odoo-dev/odoo that referenced this pull request Sep 9, 2019
In order to be able to send push notifications using recipients timezone,
the visitor timezone is now stored in DB.

The visitor timezone is only updated once, when found_visitor_timezone
cannot be found in localstorage. Once the timezone is updated,
found_visitor_timezone is added to localstorage.

Task ID : 1936643
PR odoo#34973
awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Sep 9, 2019
In order to be able to send push notifications using recipients timezone,
the visitor timezone is now stored in DB.

The visitor timezone is only updated once, when found_visitor_timezone
cannot be found in localstorage. Once the timezone is updated,
found_visitor_timezone is added to localstorage.

Task ID : 1936643
PR odoo#34973
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 9, 2019
awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Sep 11, 2019
In order to be able to send push notifications using recipients timezone,
the visitor timezone is now stored in DB.

The visitor timezone is only updated once, when found_visitor_timezone
cannot be found in localstorage. Once the timezone is updated,
found_visitor_timezone is added to localstorage.

Task ID : 1936643
PR odoo#34973
@awa-odoo awa-odoo force-pushed the odoo-dev:master-social-app-awa branch from 29e2340 to 2a3d62f Sep 11, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 11, 2019
awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Sep 20, 2019
In order to be able to send push notifications using recipients timezone,
the visitor timezone is now stored in DB.

The visitor timezone is only updated once, when found_visitor_timezone
cannot be found in localstorage. Once the timezone is updated,
found_visitor_timezone is added to localstorage.

Task ID : 1936643
PR odoo#34973
@awa-odoo awa-odoo force-pushed the odoo-dev:master-social-app-awa branch from 2a3d62f to 8beb396 Sep 20, 2019
@awa-odoo awa-odoo force-pushed the odoo-dev:master-social-app-awa branch from 9c03bfe to 29b6f4a Sep 20, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 20, 2019
The URL given to load the translations had an extra '/'.
(/website//translations/xxx)

This caused a http redirection that failed for "Mixed Content" on https environments.
awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Sep 20, 2019
In order to be able to send push notifications using recipients timezone,
the visitor timezone is now stored in DB.

The visitor timezone is only updated once, when found_visitor_timezone
cannot be found in localstorage. Once the timezone is updated,
found_visitor_timezone is added to localstorage.

Task ID : 1936643
PR odoo#34973
@awa-odoo awa-odoo force-pushed the odoo-dev:master-social-app-awa branch from 29b6f4a to e153984 Sep 20, 2019
@robodoo robodoo removed the CI 🤖 label Sep 20, 2019
dbeguin added a commit to odoo-dev/odoo that referenced this pull request Sep 20, 2019
@robodoo robodoo added the CI 🤖 label Sep 20, 2019
@@ -140,6 +142,10 @@ def _prepare_visitor_send_mail_values(self):
}
return {}

@api.model
def _tz_get(self):

This comment has been minimized.

Copy link
@tde-banana-odoo

tde-banana-odoo Sep 20, 2019

Contributor

from odoo.addons.base.models.res_partner import _tz_get

awa-odoo added a commit to odoo-dev/odoo that referenced this pull request Sep 20, 2019
In order to be able to send push notifications using recipients timezone,
the visitor timezone is now stored in DB.

The visitor timezone is only updated once, when found_visitor_timezone
cannot be found in localstorage. Once the timezone is updated,
found_visitor_timezone is added to localstorage.

Task ID : 1936643
PR odoo#34973
@awa-odoo awa-odoo force-pushed the odoo-dev:master-social-app-awa branch from e153984 to 3713b7f Sep 20, 2019
@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

@VincentSchippefilt @dbeguin only moved code from enterprise (about library). We can check for the non minimized version and add requested tests in an incoming task (FP priorities = vendredi merge).

Bisous tout plein.

@robodoo robodoo removed the CI 🤖 label Sep 20, 2019
qmo-odoo and others added 3 commits Sep 6, 2019
This commit moves the header previously defined in mass_mailing
in preparation for the cta added in the social module.

Task ID: 2045210
PR: #36416
In order to be able to send push notifications using recipients timezone,
the visitor timezone is now stored in DB.

The visitor timezone is only updated once, when found_visitor_timezone
cannot be found in localstorage. Once the timezone is updated,
found_visitor_timezone is added to localstorage.

Task ID : 1936643
PR #34973
…tracker

This method being needed in the new social app, it made sense to move it to
the link_tracker module to make it available for mass_mailing_sms and social
to avoid unnecessary duplicated code.

LINKS:

TaskID: 2045210
PR: 37143
@awa-odoo awa-odoo force-pushed the odoo-dev:master-social-app-awa branch from 3713b7f to 86a75ec Sep 20, 2019
@robodoo robodoo added the CI 🤖 label Sep 20, 2019
@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

@robodoo r+ rebase-ff

@robodoo robodoo added the r+ 👌 label Sep 20, 2019
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

Merge method set to rebase and fast-forward

robodoo pushed a commit that referenced this pull request Sep 20, 2019
In order to be able to send push notifications using recipients timezone,
the visitor timezone is now stored in DB.

The visitor timezone is only updated once, when found_visitor_timezone
cannot be found in localstorage. Once the timezone is updated,
found_visitor_timezone is added to localstorage.

Task ID : 1936643
PR #34973
robodoo pushed a commit that referenced this pull request Sep 20, 2019
…tracker

This method being needed in the new social app, it made sense to move it to
the link_tracker module to make it available for mass_mailing_sms and social
to avoid unnecessary duplicated code.

LINKS:

closes #34973

Taskid: 2045210
Pr: 37143
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

Linked pull request(s) odoo/enterprise#4879 not ready. Linked PRs are not staged until all of them are ready.

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Sep 20, 2019
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

Merged at 79bfdbf, thanks!

@robodoo robodoo closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.