Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] lunch: use new default image and fix layout #35632

Closed
wants to merge 1 commit into from

Conversation

@RomainLibert
Copy link
Contributor

commented Aug 12, 2019

The default image for the lunch product should be the one from the
category (added an image on the categories).

In case there is no image either on the product either on the category,
in the kanban view there should be a specific image (fork and knife
image)

Added some data in order to always have something displayed in the
kanban view

Fixed the layout of the dashboard

Bug fix, in _check_wallet there was a flush missing

Bug fix, product_id should be a many2one, not an integer field and the
orm should be used in order to avoid problems when favoriting products

This is a back2basics task

Task 2048246

@RomainLibert RomainLibert requested a review from tivisse Aug 12, 2019

@RomainLibert RomainLibert force-pushed the odoo-dev:master-lunch-b2b-rli branch from 25a9307 to b1943da Aug 26, 2019

@robodoo robodoo removed the CI 🤖 label Aug 26, 2019

@RomainLibert RomainLibert force-pushed the odoo-dev:master-lunch-b2b-rli branch from b1943da to 28d9702 Aug 26, 2019

@robodoo robodoo added the CI 🤖 label Aug 26, 2019

@RomainLibert RomainLibert force-pushed the odoo-dev:master-lunch-b2b-rli branch from 28d9702 to c22fc68 Aug 27, 2019

@robodoo robodoo removed the CI 🤖 label Aug 27, 2019

@RomainLibert RomainLibert force-pushed the odoo-dev:master-lunch-b2b-rli branch from c22fc68 to ff4c263 Aug 27, 2019

@robodoo robodoo added the CI 🤖 label Aug 27, 2019

@RomainLibert RomainLibert force-pushed the odoo-dev:master-lunch-b2b-rli branch from ff4c263 to ded5a25 Aug 29, 2019

@robodoo robodoo removed the CI 🤖 label Aug 29, 2019

@RomainLibert RomainLibert force-pushed the odoo-dev:master-lunch-b2b-rli branch from ded5a25 to 613563c Aug 29, 2019

@robodoo robodoo added the CI 🤖 label Aug 29, 2019

@RomainLibert RomainLibert force-pushed the odoo-dev:master-lunch-b2b-rli branch from 613563c to 863360b Sep 10, 2019

@robodoo robodoo removed the CI 🤖 label Sep 10, 2019

@RomainLibert RomainLibert force-pushed the odoo-dev:master-lunch-b2b-rli branch from 863360b to a656961 Sep 10, 2019

@RomainLibert RomainLibert changed the base branch from master to saas-12.5 Sep 10, 2019

@RomainLibert RomainLibert force-pushed the odoo-dev:master-lunch-b2b-rli branch from a656961 to cb85bab Sep 10, 2019

@robodoo robodoo added the CI 🤖 label Sep 10, 2019

[IMP] lunch: Improve the product dashboard
The default image for the lunch product should be the one from the
category (added an image on the categories).

In case there is no image either on the product either on the category,
in the kanban view there should be a specific image (fork and knife
image)

Added some data in order to always have something displayed in the
kanban view

Fixed the layout of the dashboard

Bug fix, in `_check_wallet` there was a flush missing

Bug fix, `product_id` should be a many2one, not an integer field and the
orm should be used in order to avoid problems when favoriting products

This is a back2basics task

Task 2048246

@tivisse tivisse force-pushed the odoo-dev:master-lunch-b2b-rli branch from cb85bab to efde4d6 Sep 11, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@robodoo robodoo added r+ 👌 CI 🤖 and removed CI 🤖 labels Sep 11, 2019

robodoo pushed a commit that referenced this pull request Sep 11, 2019
[IMP] lunch: Improve the product dashboard
The default image for the lunch product should be the one from the
category (added an image on the categories).

In case there is no image either on the product either on the category,
in the kanban view there should be a specific image (fork and knife
image)

Added some data in order to always have something displayed in the
kanban view

Fixed the layout of the dashboard

Bug fix, in `_check_wallet` there was a flush missing

Bug fix, `product_id` should be a many2one, not an integer field and the
orm should be used in order to avoid problems when favoriting products

This is a back2basics task

Task 2048246

closes #35632

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

@robodoo robodoo added merged 🎉 and removed merging 👷 labels Sep 11, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Merged at c0febb0, thanks!

@robodoo robodoo closed this Sep 11, 2019

@RomainLibert RomainLibert deleted the odoo-dev:master-lunch-b2b-rli branch Sep 11, 2019

switch87 added a commit to odoo-dev/odoo that referenced this pull request Sep 11, 2019
[IMP] lunch: Improve the product dashboard
The default image for the lunch product should be the one from the
category (added an image on the categories).

In case there is no image either on the product either on the category,
in the kanban view there should be a specific image (fork and knife
image)

Added some data in order to always have something displayed in the
kanban view

Fixed the layout of the dashboard

Bug fix, in `_check_wallet` there was a flush missing

Bug fix, `product_id` should be a many2one, not an integer field and the
orm should be used in order to avoid problems when favoriting products

This is a back2basics task

Task 2048246

closes odoo#35632

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.