Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] website_forum: revamp design #35749

Open
wants to merge 10 commits into
base: saas-12.5
from

Conversation

@stefanorigano
Copy link
Contributor

commented Aug 16, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD label Aug 16, 2019

@robodoo robodoo added the seen 🙂 label Aug 16, 2019

@stefanorigano stefanorigano force-pushed the odoo-dev:master-forum-design-sri branch from 59abbff to 768394d Aug 16, 2019

@stefanorigano stefanorigano marked this pull request as ready for review Aug 19, 2019

@stefanorigano

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

Hello @qsm-odoo , these two commits needs your attention:

6bb4039 : It's a workaround we found together to solve text-muted issues on cards, just to remind you

9d3a241: This "FIX" will partially revert a commit of yours and I'm not sure why you did that in the first place.

Thanks!

cc. @JKE-be

@JKE-be
Copy link
Contributor

left a comment

a first python review before to run the branch.

Thanks and sorry for comment...

addons/website_forum/models/forum.py Show resolved Hide resolved
addons/website_forum/controllers/main.py Outdated Show resolved Hide resolved
addons/website_forum/static/src/js/website_forum.js Outdated Show resolved Hide resolved
addons/website/views/website_templates.xml Outdated Show resolved Hide resolved
if not forum.can_access_from_current_website():
raise werkzeug.exceptions.NotFound()

website_domain = request.website.website_domain()
forums = request.env['forum.forum'].search(website_domain)

This comment has been minimized.

Copy link
@JKE-be

JKE-be Aug 19, 2019

Contributor

if I'm not wrong you just use it to know if you need to display All forums in breadcrumb.

In this case, you can just use search_count instead of search. It will just return the count of row, instead of each id of row.

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Aug 21, 2019

Author Contributor

Perfect, thanks!
I may replace it with:

website_domain = request.website.website_domain()
forums_count = request.env['forum.forum'].search_count(website_domain)

There is an issue though... I need to check for this value on each forum page (the button is in the navbar), not only on this template. Should I clone this logic for each controller?

addons/website_forum/controllers/main.py Show resolved Hide resolved
@qsm-odoo
Copy link
Contributor

left a comment

I only reviewed the 2 commits you told me about ;)

addons/portal/static/src/scss/portal.scss Outdated Show resolved Hide resolved
addons/web/static/src/scss/bootstrap_review.scss Outdated Show resolved Hide resolved
addons/website/views/website_templates.xml Outdated Show resolved Hide resolved

@stefanorigano stefanorigano force-pushed the odoo-dev:master-forum-design-sri branch 2 times, most recently from 3177d9d to 2029cce Aug 21, 2019

@stefanorigano

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

Hello @JKE-be , any news on this? Do you need something?
Let me know about #35749 (comment) ;)

I only reviewed the 2 commits you told me about ;)

@qsm-odoo I've seen this only now ^^

@JKE-be

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

Hello, I don't really take the time for now, we still have 3 (+2) others branch in the pipe for this freeze too to be merged with model changes.

But, your branch don't change the model so can be merged later.
Your branch is a nice to have but already redisigned in 12.3 so in the worst case, it's ok for later version. But we all hope to merge it in v13

And we have some branches like mega menu that should have help of designer to work on it... If you are interested, it is ~key feature of v13 for website and we still have a rough layout.

I still don't know who will handle the python changes, you or me, you never reply to my previous comment. If it's me, I will check it after review of xml/scss by @qsm-odoo during the final review before the push.

@stefanorigano

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

I still don't know who will handle the python changes, you or me, you never reply to my previous comment.

Again, I'm not able to code python. If during a PR review you ask me to simplify your job replacing A with B, I'll definitively try to do that (as I already did), it doesn't bores me at all.
But you should decide if ask according to your needs/workflow, it's not on me :)

Your branch is a nice to have but already redisigned in 12.3 [...] And we have some branches like mega menu that should have help of designer to work on it. If you are interested

For what I know this was an ASAP Fix, not a "nice to have". Please, next time let me know so I can focus on other ongoing projects ;)
For new website tasks I should check priorities with FP, currently I have others big refactoring concerning other teams (eg gantt view).

Thanks

@stefanorigano

This comment was marked as resolved.

Copy link
Contributor Author

commented Aug 29, 2019

@JKE-be , moderation tool is visible in mobile.
You have to check the "Go to" menu on the top.

@stefanorigano

This comment was marked as resolved.

Copy link
Contributor Author

commented Aug 29, 2019

Can we also re-add Newest and Trending in the forum menu because it is probably the 2 most used button ;) now it is only available in the sort by dropdown

Unfortunately there is not enough room for sorting methods shortcuts... people we'll have to use the menu I guess... If you think that trending is more important we can set is as default ordering mode though.

Is there a reason to don't display the sort by when you use filter Answered / Unanswered / unsolved , it is only available in case of all post?

Yep, it's hidden if the number of posts is < 2 (in that case you have nothing to order)

@stefanorigano

This comment was marked as outdated.

Copy link
Contributor Author

commented Aug 29, 2019

@JKE-be ,

Can we also try to find a solution like you did for slide, about the Users submenu.
Since website_profile take the power on it, when you are on the forum and switch to the users, you have no easy way to come back on the current forum.

I totally agree, there is a navigation issue there. I initially tried using a special URL for links to profile and use request.params.get('XXX') in profile to detect that the user is coming from forum, but the btn was targeting the main forum page rather than the 'last visited page' ( like the browser 'back button'), it was not good.
Do you have suggestions?

addons/website_forum/controllers/main.py Outdated Show resolved Hide resolved
addons/website_forum/controllers/main.py Outdated Show resolved Hide resolved
if tag_char:
active_char_tag = tag_char.lower()

active_char_tag = tag_char and tag_char.lower() or 'all'

This comment has been minimized.

Copy link
@JKE-be

JKE-be Aug 29, 2019

Contributor

Old code was smarter ;)

If you take main forum of Odoo, you will see that you need several minute to display the all tags page or to see that the page is crashed...
In most of the case, when you click on tag, you will click after on another letter.

So for performance issue, we decide to display the first letter of the first tag, instead of all tag.
Can you revert to old code plz

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Aug 30, 2019

Author Contributor

Yes, indeed, I know that this expose a problem ( know issues in the pad).

Fp asked to improve performance here, the user should be able to see all tags without crashes (I imported odoo.com tags in my local instance to test).
Currently we render a website_mail.follow for each tag, can we do that "on hover" only using JS?

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Aug 30, 2019

Author Contributor

Currently we render a website_mail.follow for each tag, can we do that "on hover" only using JS?

not sure, just an idea

This comment has been minimized.

Copy link
@JKE-be

JKE-be Aug 30, 2019

Contributor

no interest to display 5111 imo in one page...

We can use pager btw to catch this problem... but that continue to be an useless page ;)

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Aug 30, 2019

Author Contributor

no interest to display 5111 imo in one page...

^^ There should not be 5000 tags in the first place, but I got your point.
Let's assume you have a normal number of tags, having all of them in one page it's perfect, you can scroll and decide which one subscribe. Proposal:

tags < X
    'ALL' is default
tags > X
    'A' is default (not 0), hide the 'ALL' button

Also, we should avoid to let the user create duplicates using suggestion... eg in our forum we have: v7, v.7, v7.0, task, tasks....

This comment has been minimized.

Copy link
@JKE-be

JKE-be Aug 30, 2019

Contributor

If you find a way to educate the end user... I take it...
By default, all news users cannot create tag, maybe we should increase the karma limit :)

An task exists about merge of tag by Lemmatisation, but we don't really want it in Odoo.
PR 32386

Problem is to have website without moderator, or let user with small karma create it, or just don't suggest good tags to help them to find the existing similar tag...
If we avoid the creation of wrong tag, we will not need to merge it;)

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Sep 2, 2019

Author Contributor

Yes, to avoid unnecessary tags creation would be nice.
What about my proposal for the tags page?

tags < X
    'ALL' is default
tags > X
    'A' is default (not 0), hide the 'ALL' button

This comment has been minimized.

Copy link
@JKE-be

JKE-be Sep 2, 2019

Contributor

as well your solutions, as well a pager... everything is good for me ;)

Be awrae, that the first selected is not really 0, but the first 'first letter' from all tag sorted.

So if you have tags: 20, v12, lucky, 50
you will have [2,5,L,V] => 2 as first selected tag

btw, does it take sense to use interger as tag ;) not really sure...

addons/website_forum/views/website_forum.xml Outdated Show resolved Hide resolved
addons/website_forum/views/website_forum.xml Outdated Show resolved Hide resolved
addons/website_forum/views/website_forum.xml Outdated Show resolved Hide resolved
addons/website_forum/views/website_forum.xml Outdated Show resolved Hide resolved
@JKE-be

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

Do you have suggestions?

You can use back=request.httprequest.path and be sure in profile to prepend this with current domain to avoid openredirect issue

@stefanorigano

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@JKE-be ,

about the toggle of validate_answer, we refresh to make it simple because e.g. tag 'best answer' should be moved from the old one to the new one.. what make many js for a few details, so refresh was more easy... I let you decide what's the best todo for you ;)

👍

"Followed tags" in right columns seems broken, if you don't find the fix, let me know and I or We can check that. Actually, when you select "Followed posts" , follow post and tag are both selected.

Yep, it's the the pad's know issues/missing implementation list. There is no controller for this at the moment, it's a new feature.

When you try to delete a comment, the comment don't disappear for now. In Js there a code ~ $link.parents('.comment') but, there ar eno more class comment to find the commend to hide

👍

@JKE-be

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

@JKE-be , moderation tool is visible in mobile.
You have to check the "Go to" menu on the top.

Imo, it is not enough...
When you read a post on the forum and is moderator; As soon as you see that there are waiting post, you will moderate it...
But if you need to make click to see if at least one post is in the queue, the delay will increase a lot. And poeple will not check...

@stefanorigano

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@JKE-be , moderation tool is visible in mobile.
You have to check the "Go to" menu on the top.

Imo, it is not enough...
When you read a post on the forum and is moderator; As soon as you see that there are waiting post, you will moderate it...
But if you need to make click to see if at least one post is in the queue, the delay will increase a lot. And poeple will not check...

Ok, I got it. What about adding shortcuts icon beside the "Go to" menu?

data-toggle="popover" data-trigger="hover" data-content="Please wait for a moderator to validate your previous post before continuing.">
<a class="disabled btn btn-secondary btn-block mb-3 mb-md-0" t-attf-href="/forum/#{slug(forum)}/ask">Ask a Question</a>
</div>
<a t-elif="uid" role="button" type="button" class="btn btn-primary btn-block o_forum_ask_btn mb-3 mb-md-0" t-attf-href="/forum/#{slug(forum)}/ask">Ask a Question</a>

This comment has been minimized.

Copy link
@sbuhl

sbuhl Aug 30, 2019

Don't know where to put this: https://tinyurl.com/y6nekej5
On mobile, I create a new question, I click on "Go To"
The dropdown over the edition box, but the tool bar is over.

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Aug 30, 2019

Author Contributor

I'll take care of this, thanks

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Aug 30, 2019

Author Contributor

@sbuhl , I can replicate this :/
Which browser are you using?

This comment has been minimized.

Copy link
@sbuhl

sbuhl Sep 2, 2019

On Chrome with dev tools

@stefanorigano stefanorigano force-pushed the odoo-dev:master-forum-design-sri branch from b1a55d4 to 79dfa7e Aug 30, 2019

@stefanorigano

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

Hello @JKE-be , a little summary, thanks!

Done, but I'm not sure:

  • Navigate back from the profile pages(s), pushed here 9bbe4a4
    The resulting url it's something like /profile/user/2?forum_id=1&forum_origin=/forum/help-1/question/how-to-configure-alerts-for-employee-contract-expiration-1, not sure if it's ok.

To define if/how implement:

I'm not able to:

  • 'Followed Tags' menu-item, in the user sidebar: implementation missing
  • Setting a topic as "Favourite" should automatically make following it
  • "No-image" avatar, use the backend "Contacts" ones rather than camera icon

@stefanorigano stefanorigano force-pushed the odoo-dev:master-forum-design-sri branch from a5d29a2 to 68a0dd5 Sep 3, 2019

@qsm-odoo qsm-odoo changed the base branch from master to saas-12.5 Sep 3, 2019

@qsm-odoo
Copy link
Contributor

left a comment

Result looks good :) Here are some random comments circling through your diff. I'll continue tomorrow, some other stuff to check today :)

addons/website_forum/static/src/js/website_forum.js Outdated Show resolved Hide resolved
addons/website_forum/static/src/js/website_forum.js Outdated Show resolved Hide resolved
addons/website_forum/views/website_forum.xml Outdated Show resolved Hide resolved
addons/website_forum/views/website_forum.xml Outdated Show resolved Hide resolved
addons/website_forum/static/src/js/website_forum.js Outdated Show resolved Hide resolved

@stefanorigano stefanorigano force-pushed the odoo-dev:master-forum-design-sri branch from b996781 to cf858a0 Sep 5, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

I am working on it, so before you start working again, ask me ;)

@stefanorigano

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@qsm-odoo

@stefanorigano Do we really want to enable code view for forum visitors ?

The aim was to allow "html skilled" users to solve on the fly some editor issues, but it's probably not a good idea. I'll remove it.
Please, have a look at this list (#35749 (comment))

I am working on it, so before you start working again, ask me ;)

ok

@qsm-odoo
Copy link
Contributor

left a comment

@stefanorigano I am working on this, so do not touch the branch but could you answer my first two questions here? :)

addons/website_forum/static/src/js/website_forum.js Outdated Show resolved Hide resolved
<a t-attf-class="vote_up fa fa-caret-up no-decoration #{own_vote == 1 and 'text-success' or ''} #{((own_vote == 1 and not can_downvote) or not can_upvote) and 'karma_required' or ''}"
<div t-attf-class="vote text-center d-inline-flex align-items-center #{vertical and 'o_wforum_vote_vertical flex-md-column'} #{classes}">
<a t-attf-class="btn vote_up fa fa-caret-up pl-0 #{'px-md-0 pt-md-0' if vertical else 'pr-2'} #{own_vote == 1 and 'disabled text-success'} #{((own_vote == 1 and not can_downvote) or not can_upvote) and 'karma_required'}"
data-active-class="text-success"
t-attf-data-karma="#{own_vote == 1 and karma_down or karma_up}"

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Sep 11, 2019

Contributor

The display/animation of the feature appears broken since at least 12.0 but before your refactoring, someone was able to remove its upvote or downvote (by either clicking on the same button or click on the other button). I think this should stay, if I click by mistake it seems to be legit to remove the vote don't you think ? (and otherwise, all the code here is dead...)

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Sep 11, 2019

Author Contributor

but before your refactoring, someone was able to remove its upvote or downvote (by either clicking on the same button or click on the other button).

Sure, but It should still be the case actually. I'm testing the branch, I can upvote and then downvote. The following code should not be dead, it sets the initial state (if you previously upvoted, downvoted). I'm probably missing something

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Sep 11, 2019

Contributor

No, you are marking the button as disabled and the behavior is broken when clicking on the other button.

Simple flow:

  • The score is currently 9
  • I hit "up vote" by mistake -> the score is now 10 and it's green
  • I want to remove by reclicking, I can't
  • I try hitting the "down vote" instead -> the score is now back to 9... but it's red ?
  • I am not able to "down vote" to 8 since it is now disabled
  • I reload the page and it is still 9 but not red anymore

I refactored the JS/XML in my branch but the behavior is still the same... what would be the behavior you wanted? ;)

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Sep 11, 2019

Author Contributor

Ok, I got it. The overall approach is right, but have you spot a bug.

what would be the behavior you wanted? ;)

Exactly the same as reddit:

  1. Score is 9
  2. hit Upvote -> the score is now 10 (and it's blue)
  3. hit Upvote gain -> nothing happens
  4. hit Downvote > the score is now 9 (and it's gray)
  5. hit Downvote again > the score is now 8 (and it's red)
  6. Reload the page > the score is now 8 (and it's red)

We fail the last 3 points

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Sep 11, 2019

Contributor

Mmh, I guess if reddit does this... I suppose our original behavior is the one of stackoverflow and it feels better to me :/ I would personally never dare hitting the down vote button to undo my up vote... Anyways, I'll fix this in my branch now to match what you desired.

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Sep 11, 2019

Contributor

In fact, I will push my refactoring with the broken behavior today and speak with @JKE-be tomorrow about this. The code seems too broken in stable version to me to think about it x) Reading the code, it seems that you could remove your upvote directly if not reloading the page and may not have enough karma to do it after reloading the page

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Sep 16, 2019

Contributor

@JKE-be Still need to talk about this in fact... :/

@qsm-odoo
Copy link
Contributor

left a comment

addons/website_forum/static/src/js/website_forum.js Outdated Show resolved Hide resolved
addons/website_forum/static/src/js/website_forum.js Outdated Show resolved Hide resolved

// Hide button and show 'bell' icon for logged-in users that
// are not followers.
.o_connected_user & > div[data-follow="off"] > div {

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Sep 11, 2019

Contributor

Should find another way

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Sep 11, 2019

Author Contributor

Can't xpath website_mail.follow without changing its content for all others modules too. What do you suggest?

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Sep 11, 2019

Contributor

Why not the bell in website_mail directly ?

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Sep 12, 2019

Author Contributor

I'm hesitant because this bell design is tailored for this section only.
In the tags page, for example, we should keep the button... the same in website_blog and the event modules.

An option may be to refactor the original template ad trigger the "icons only" design using a qweb variable.... eg <t t-if="icon_design">
Or maybe something like this but I'm not sure if it's suitable
https://github.com/odoo/odoo/blob/12.0/addons/website_mail_channel/views/website_mail_channel_templates.xml#L53

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Sep 12, 2019

Contributor

I don't know what you are showing me with the link but I suppose it is ok to refactor the original template to allow switching it into a bell-design depending on a variable ;)

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Sep 16, 2019

Contributor

@stefanorigano are you working on this? :)

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Sep 16, 2019

Author Contributor

@qsm-odoo , not yet. Realistically I may have time tomorrow afternoon.
If it's urgent I'd suggest to proceed and I'll check the design afterwards.

This comment has been minimized.

Copy link
@stefanorigano

stefanorigano Sep 17, 2019

Author Contributor

@qsm-odoo , please have a look to this test 3cef610
thanks

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Sep 18, 2019

Contributor

Seems ok to me, just don't name the new class js_follow_icons_container but something respecting our convention like o_wmail_follow_icons_container

margin: 0;
font-size: 18px;
}
.o_wforum_bio_popover_info .css_editable_mode_hidden > .mt-2 {

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Sep 11, 2019

Contributor

Cannot target an mt-2.

This comment has been minimized.

Copy link
@qsm-odoo
</div>
</div>
</t>
<t t-if="followed">
<div class="mb32">
<div class="mb4">

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Sep 11, 2019

Contributor

When you change mbXX classes, try using the ones from bootstrap now ;)

addons/website_forum/views/website_forum.xml Outdated Show resolved Hide resolved
@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@stefanorigano Once you will have checked and replied to my comments, I'll push my work on top of the branch (which will resolve half of my comments). I also fixed the collapse of comments problem. I'll put all of this in a separate commit so that you can have a look (yesterday I squashed directly in yours). You will then be able to touch the branch again ;)

I will let the debate about the tags to you and JKE, I did not understand when reading it from your conversation.

switch87 added a commit to odoo-dev/odoo that referenced this pull request Sep 11, 2019
[IMP] web_editor, *: introduce wysiwyg frontend loader
* website_forum, website_profile

- Share some code between website_forum and website_profile by exposing
  a function in web_editor to instantiate a wysiwyg instance on a
  textarea

- Use no-lazy loaded JS to add a visual loading effect while the
  wysiwyg is not yet available.

This is made in preparation of task-2024197
(see odoo#35749)

Thanks to @stefanorigano

closes odoo#36581

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@stefanorigano Thanks for checking, I pushed my commit on top 472b9e1 you can now fetch and work on the branch again if you want to ;) Let's say the plan is to solve the remaining points tomorrow so that it is merged friday 👍

@stefanorigano

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

@qsm-odoo , we can finally see a light at the end of the tunnel ^^

I also fixed the collapse of comments problem.

Thanks!

I will let the debate about the tags to you and JKE, I did not understand when reading it from your conversation.

If I have understood well, for @JKE-be my proposal is fine , #35749 (comment).
It's already partially implemented, some python checks are missing, a brief recap of the desired behaviour :

  • By default the [ALL] pagination btn is selected. (done)
  • If tags number > X, hide the [ALL] btn and select resulting first letter , eg. [A]
  • If pagination btn number > 11, replace the pagination with a dropdown (to avoid horizontal overflow/ broken layout) (done)
  • "Probably not very useful to use integer number as tags" (to check with JKE)
  • Fp wants to "increase performance", maybe loading the website_mail.follow on hover rather than for each tag (??) - I let you guys decide

X = number of tags that make the browser crash (eg. https://www.odoo.com/forum/help-1/tag/all)

qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Sep 16, 2019
qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Sep 16, 2019
qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Sep 16, 2019
[FIX] website_forum, *: review header nav layout
* website_slides_forum

Move the '.container' inside the navbar in order to avoid unnecessary
horizontal padding.

Part of odoo#35749
task-2024197
qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Sep 16, 2019

@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-forum-design-sri branch from 472b9e1 to a5d9a69 Sep 16, 2019

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

I just rebased

stefanorigano and others added 9 commits Jun 11, 2019
[FIX] website_forum, *: review header nav layout
* website_slides_forum

Move the '.container' inside the navbar in order to avoid unnecessary
horizontal padding.

Part of #35749
task-2024197
[IMP] website_event_questions: remove redundant <data> element
Since this is template extension, the `<data>` element has no effect.

closes #35425

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
[FIX] core: compatibility with Werkzeug 0.15 ProxyFix
Werkzeug 0.15 modified ProxyFix such that by default it only forwards
the REMOTE_ADDR when enabled, whereas before 0.15 it would also
forward scheme and host. This breaks proxied odoo as the base url
becomes incorrect (cf #34412).

Use properly configured ProxyFix when running with werkzeug 0.15, old
configuration otherwise.

Closes #35085

closes #36212

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

@stefanorigano stefanorigano force-pushed the odoo-dev:master-forum-design-sri branch from a5d9a69 to 1c3dc9d Sep 17, 2019

@stefanorigano

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2019

@qsm-odoo , please check 3cef610 (website_mail follow button)

I removed the resizable title.

Is this #35749 (comment) the only remaining thing on my side?
Thanks

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

@stefanorigano I think so, I'll adapt the vote up/down after discussion with sbu and I think JKE started working on the tags. Tell me once you stop working on the branch 😉

@stefanorigano

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2019

@stefanorigano I think so, I'll adapt the vote up/down after discussion with sbu and I think JKE started working on the tags. Tell me once you stop working on the branch 😉

I'm not on it right now, I'll probably came back on it this evening/tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.