Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] ecommerce: custom ribbons #36429

Open
wants to merge 3 commits into
base: master
from

Conversation

@kea14
Copy link
Contributor

commented Sep 4, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD label Sep 4, 2019
Copy link
Contributor

left a comment

@kea14 Come on... No JS was required at all here... The spec is clear: transform the "Image Full" product.style in a customize_show view which enables the related style for all products. So... to split the step1 even further...

  1. Remove the "Image - Full" product.style
  2. Create a customize_show view with the same name
  3. When enabled, that customize_show view adds the related style for all products during the rendering of the shop grid

This is a 1 hour task. It is just removing and moving stuff... probably more removing than moving...

How would you defend your work here ? You use JS to flag a customize option when the key contains a hard-coded string, you include the customize menu to allow enabling a product.style (that you target by name...) for all products (which I don't even know how it could work since you don't know the product ids... and what if we create a product afterwards?), ... also why would it be step 1 of the ribbon task ? Did you try to understand how the product.style model work doing this ?

@kea14

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

@qsm-odoo Thanks, I get it, it was pretty obvious indeed

@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from 4e5010c to 7c1b8ab Sep 5, 2019
@kea14

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

@qsm-odoo So I guess this is something like that for step1, right ?

@robodoo robodoo removed the CI 🤖 label Sep 5, 2019
addons/website_sale/views/templates.xml Outdated Show resolved Hide resolved
@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from 7c1b8ab to dde99b2 Sep 23, 2019
addons/website_sale/views/templates.xml Outdated Show resolved Hide resolved
addons/website_sale/views/templates.xml Outdated Show resolved Hide resolved
@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from dde99b2 to c2d3395 Sep 23, 2019
@robodoo robodoo added the CI 🤖 label Sep 23, 2019
@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from c2d3395 to 0fbd350 Sep 24, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 24, 2019
@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from 0fbd350 to 39fc561 Sep 25, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 25, 2019
@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from 39fc561 to cf22959 Sep 27, 2019
@robodoo robodoo removed the CI 🤖 label Sep 27, 2019
@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from cf22959 to 22edb83 Sep 30, 2019
@robodoo robodoo added the CI 🤖 label Sep 30, 2019
@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from 22edb83 to ec9ead1 Oct 1, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 1, 2019
@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from ec9ead1 to 548d8cd Oct 7, 2019
@robodoo robodoo removed the CI 🤖 label Oct 7, 2019
@robodoo robodoo added the CI 🤖 label Oct 7, 2019
@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from 548d8cd to 2b7cf3c Oct 9, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 9, 2019
@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from 2b7cf3c to 5e88286 Oct 10, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 10, 2019
kea14 added 2 commits Sep 23, 2019
This commit transforms the "Image Full" option which is per product in a
customize_show view which enables the same style for all products at the
same time.

task-1981170
@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from 5e88286 to 507f53e Oct 11, 2019
@robodoo robodoo removed the CI 🤖 label Oct 11, 2019
*: web_editor

This commit brings the possibility to create custom ribbons to put on
products on the shop page.

task-1981170
@kea14 kea14 force-pushed the odoo-dev:master-ecommerce-custom-ribbons-aul branch from 507f53e to e21690b Oct 11, 2019
@kea14

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2019

In a few words, this task seems almost over. I'll re-reading everything and re-do some tests on Monday.

@robodoo robodoo added the CI 🤖 label Oct 11, 2019
@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2019

Why not but a bit afraid of the code, I think the task can be done in 30lines if we take advantage of the backend... you should speak of the specs with the team during the development... :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.