Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[IMP] ecommerce: custom ribbons #36429
qsm-odoo left a comment
@kea14 Come on... No JS was required at all here... The spec is clear: transform the "Image Full" product.style in a customize_show view which enables the related style for all products. So... to split the step1 even further...
This is a 1 hour task. It is just removing and moving stuff... probably more removing than moving...
How would you defend your work here ? You use JS to flag a customize option when the key contains a hard-coded string, you include the customize menu to allow enabling a product.style (that you target by name...) for all products (which I don't even know how it could work since you don't know the product ids... and what if we create a product afterwards?), ... also why would it be step 1 of the ribbon task ? Did you try to understand how the product.style model work doing this ?
This commit transforms the "Image Full" option which is per product in a customize_show view which enables the same style for all products at the same time. task-1981170