Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] point_of_sale: Small changes to the POS Config view #36495

Closed

Conversation

@aprieels
Copy link
Contributor

commented Sep 6, 2019

An "iface_payment_terminal" field was present but never used. We
remove it.

Add a class on the list of IoT Devices to override it easily in pos_iot
and increase the width of the labels.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Sep 6, 2019

@aprieels aprieels force-pushed the odoo-dev:saas-12.5-pos-select-iot-devices-anp branch from 611e8de to 3663be6 Sep 6, 2019

@C3POdoo C3POdoo added the RD label Sep 6, 2019

@aprieels aprieels force-pushed the odoo-dev:saas-12.5-pos-select-iot-devices-anp branch 2 times, most recently from ab6c296 to 099edde Sep 6, 2019

@robodoo robodoo added the CI 🤖 label Sep 10, 2019

@aprieels aprieels force-pushed the odoo-dev:saas-12.5-pos-select-iot-devices-anp branch from 099edde to 1d9ec39 Sep 10, 2019

@robodoo robodoo removed the CI 🤖 label Sep 10, 2019

@aprieels aprieels requested a review from qle-odoo Sep 10, 2019

@robodoo robodoo added the CI 🤖 label Sep 10, 2019

@aprieels aprieels added the IoT label Sep 10, 2019

@qle-odoo qle-odoo requested a review from pimodoo Sep 10, 2019

<span class='js_msg oe_orange oe_hidden'></span>
<div class="js_connected oe_icon oe_green">
<div class="js_connected oe_green">
<span class='js_msg oe_hidden'></span>

This comment has been minimized.

Copy link
@pimodoo

pimodoo Sep 10, 2019

Contributor

can you double quote the one all your 'js_msg oe_hidden', it will be beautifful in futurewhen all lines will be changed

@aprieels aprieels force-pushed the odoo-dev:saas-12.5-pos-select-iot-devices-anp branch from 1d9ec39 to 9ae9ed1 Sep 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 11, 2019

@aprieels aprieels force-pushed the odoo-dev:saas-12.5-pos-select-iot-devices-anp branch from 9ae9ed1 to 68e026d Sep 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 11, 2019

aprieels added 4 commits Sep 6, 2019
[FIX] point_of_sale: remove unused field
An "iface_payment_terminal" field was present but never used. We
remove it.
[IMP] point_of_sale: Small changes to the POS Config view
Add a class on the list of IoT Devices to override it easily in pos_iot
and increase the width of the labels.
[IMP] point_of_sale: Show message on proxy icon
Add the possibility to show a message on the proxy status icon in the
PoS. The message will be the same color than the status icon.
[REM] hw_drivers: Remove printers list from status
The status returned bby PrinterDriver contained a list of connected
printers to be used in Enterprise, to determine if the printer that was
selected in POS Config was used in the POS. We now read this status
from the db and we therefore don't need this anymore.

In Community the user only needs to know if there's a printer connected
to the Box. We just have to know if any printer is present.

TaskID: 1970884

@aprieels aprieels force-pushed the odoo-dev:saas-12.5-pos-select-iot-devices-anp branch from 68e026d to 5a33bee Sep 17, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 17, 2019

@qle-odoo

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

@robodoo r+ rebase-merge

@robodoo robodoo added the r+ 👌 label Sep 18, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Merge method set to rebase and merge, using the PR as merge commit message

@robodoo

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Linked pull request(s) odoo/enterprise#5429 not ready. Linked PRs are not staged until all of them are ready.

robodoo added a commit that referenced this pull request Sep 18, 2019
[IMP] point_of_sale: Small changes to the POS Config view
An "iface_payment_terminal" field was present but never used. We
remove it.

Add a class on the list of IoT Devices to override it easily in pos_iot
and increase the width of the labels.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes #36495

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

Merged at c3f6f1f, thanks!

@robodoo robodoo closed this Sep 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.