Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master https social app awa utm campaigns again qmo #36632

Open
wants to merge 8 commits into
base: saas-12.5
from

Conversation

@qmo-odoo
Copy link

commented Sep 10, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

awa-odoo and others added 5 commits May 16, 2019
[IMP] web: add capability to disable records drag/drop on kanban views
This commit adds a recordsDraggable option on the kanban view that allows to completly disable
the drag and drop feature.

This is a preliminary work for the social 'Feeds' kanban where the user should not be able to drag and drop posts.
[FIX] fix translations URL in translation.js
The URL given to load the translations had an extra '/'.
(/website//translations/xxx)

This caused a http redirection that failed for "Mixed Content" on https environments.
[IMP] website : store visitor timezone
In order to be able to send push notifications using recipients timezone,
the visitor timezone is now stored in DB.

The visitor timezone is only updated once, when found_visitor_timezone
cannot be found in localstorage. Once the timezone is updated,
found_visitor_timezone is added to localstorage.

Task ID : 1936643
PR #34973
[IMP] link_tracker: Add global click count on campaign
This commit adds a global click count field to
the utm.campaign.

Task ID: 2045210
PR: #36416

This commit replaces the global click ratio
@qmo-odoo

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

@awa-odoo
Copy link
Contributor

left a comment

To check before cherry-picking

@api.depends('mailing_items', 'mailing_clicked')
def _compute_items_total(self):
super(UtmCampaign, self)._compute_items_total

This comment has been minimized.

Copy link
@awa-odoo

awa-odoo Sep 10, 2019

Contributor

Missing "()"

Leads me to wonder if you have tested mailing + social and check that stats are correctly summed.
Might be worth to check...

@@ -23,6 +23,9 @@
<field name="model">utm.campaign</field>
<field name="arch" type="xml">
<form string="UTM Campaign">
<header style="min-height:31px;">

This comment has been minimized.

Copy link
@awa-odoo

awa-odoo Sep 10, 2019

Contributor

Inline-style :(
Also why?

[IMP] utm: Add header to utm.campaign form
This commit moves the header previously defined in mass_mailing
in preparation for the cta added in the social module.

Task ID: 2045210
PR: #36416

@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-https-social-app-awa-utm-campaigns-again-qmo branch from d079af0 to df0f320 Sep 10, 2019

@robodoo robodoo removed the CI 🤖 label Sep 10, 2019

@C3POdoo C3POdoo added the RD label Sep 10, 2019

@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-https-social-app-awa-utm-campaigns-again-qmo branch from df0f320 to 016f41c Sep 10, 2019

@robodoo robodoo added the CI 🤖 label Sep 10, 2019

qmo-odoo added 2 commits Sep 6, 2019
[IMP] utm, mass_mailing: Clean utm.campaign + stat button
This commit cleans up the utm.campaign form view by:
  * Don't display mailing related things if no mailings
    on the campaign or if the campaigns were not activated
    in mass_mailing settings
  * Stat button for the mass mailings was wrong, it was displaying the number
    of mails instead of the number of mailings
  * Remove unused global click ratio field all other fields/methods related
    to its computation

Task ID: 2045210
PR: #36416
[IMP] mass_mailing: Add groups on mailing related fields
This commit adds groups on mass_mailing related fields of the utm campaign
to prevent access rights issue in case campaigns are used in other applications
(Social).

Task ID: 2045210
PR: #36416

@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-https-social-app-awa-utm-campaigns-again-qmo branch from 016f41c to f7514a6 Sep 11, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.