Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] product_expiry: Improve usability when working with expiration dates #36680

Open
wants to merge 12 commits into
base: master
from

Conversation

@svs-odoo
Copy link
Contributor

commented Sep 11, 2019

◾️ Adds boolean on product.product to user can use expiration dates on tracked product (otherwise the date section will be invisible).
◾️ Changes label and tooltip of product.product and stock.production.lot date fields.
◾️ Displays removal_date on quant list view.
◾️ Can set the life_date on receipt.
◾️ Displays Best before date and Expiration Date on LN/SN pdf.

@robodoo robodoo added the seen 🙂 label Sep 11, 2019
@C3POdoo C3POdoo added the RD label Sep 11, 2019
@robodoo robodoo added the CI 🤖 label Sep 11, 2019
@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch from ed8d3eb to a56c960 Sep 12, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 12, 2019
@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch from a56c960 to bea6e6c Sep 12, 2019
@robodoo robodoo removed the CI 🤖 label Sep 12, 2019
@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch 2 times, most recently from bae1d75 to fe74e95 Sep 13, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 13, 2019
@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch from 2c0af08 to 2fb2f74 Sep 19, 2019
@robodoo robodoo removed the CI 🤖 label Sep 19, 2019
@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch 4 times, most recently from 3d4d8e2 to 2e03966 Sep 19, 2019
@robodoo robodoo added the CI 🤖 label Sep 23, 2019
@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch from 2e03966 to 11882e8 Sep 24, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 24, 2019
@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch from 11882e8 to f57a42e Sep 25, 2019
@robodoo robodoo removed the CI 🤖 label Sep 25, 2019
@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch from f57a42e to 6ebb3e8 Sep 25, 2019
@robodoo robodoo added the CI 🤖 label Sep 25, 2019
@amoyaux

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

Also do not forget to squash the commit with confirmation message :)

<field name="inherit_id" ref="stock.view_stock_move_line_operation_tree"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='lot_name']" position="after" >
<field name="expiration_date" attrs="{'column_invisible': ['|', ('parent.use_expiration_date', '!=', True), ('parent.picking_code', '!=', 'incoming')]}"/>

This comment has been minimized.

Copy link
@amoyaux

amoyaux Oct 17, 2019

Contributor

would be better to check on location dest and location src. We avoid using picking code to do it. It certainly works but other methods/views are based on location and not picking code.

@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch from c867628 to f6c8f10 Oct 18, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 18, 2019
svs-odoo added 4 commits Sep 9, 2019
Adds new product field, `use_expiration_date`, to know if user wants to
use expiration date on product. Only accessible when product is tracked.

Also, changes fields' name:
    - product.template:     life_time becomes expiration_time
    - stock.production.lot: life_date becomes expiration_date

Task #1938656
Changes the label and tooltip of expiration date related fields.

Task #1938656
Computes production_lot date fields when the user manually changes the
`life_date` field.

Task #1938656
Sets quant lines in red if removal date has been exceeded.

Task #1938656
svs-odoo added 3 commits Sep 9, 2019
Adds a search filter on quant list for expired lot.

Task #1938656
User can now define the lot's field `expiration_date` when he/she
receipts a tracked product using the expiration dates.

Task #1938656
Adds "Best before date" and "Expiration Date" on LN/SN pdf report.

Task #1938656
@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch from f6c8f10 to c06874f Oct 21, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 21, 2019
svs-odoo added 3 commits Sep 13, 2019
When user tries to validate a picking with expired production lot,
displays a wizard for the confirmation popup. This wizard shows which
lots are expired.

Task #1938656
Adds "Best before date" and "Expiration Date" on LN/SN ZPL print format.

Task #1938656
The production lot expiry alert was based on the field `alert_date`.
Now, it will be based on the field `life_date` since if user set only
one field, there is more chance this field will be filled but the field
`alert_date` will not.

Task #1938656
@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch from c06874f to 10350b7 Oct 21, 2019
@robodoo robodoo removed the CI 🤖 label Oct 21, 2019
@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch from 10350b7 to 91c1ff7 Oct 21, 2019
svs-odoo added 2 commits Oct 9, 2019
When user produces for a Manufacturing Order, if he/she uses an expired
component, a confirmation wizard will ask if he/she really wants to use
this component.

Task #1938656
With product_expiry, when a workorder is done, we check if there is
expired lot in components. If it is, we ask confirmation to the user.

Task #1938656
@svs-odoo svs-odoo force-pushed the odoo-dev:master-expiration-date-svs branch from 91c1ff7 to ed028ee Oct 21, 2019
@robodoo robodoo added the CI 🤖 label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.