Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11.0 website sale fix fja #37141

Closed
wants to merge 1 commit into from

Conversation

@fja-odoo
Copy link
Contributor

commented Sep 19, 2019

The cart popover did not have any max length, now it will not go out of
the page if there is a lot of products in it.

Shop page link and popover use the same route which make a write on db
to recompute coupon lines. Can lead to concurent updates if unlucky on
timing.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Sep 19, 2019
@C3POdoo C3POdoo added the RD label Sep 19, 2019
@robodoo robodoo added the CI 🤖 label Sep 19, 2019
@fja-odoo fja-odoo force-pushed the odoo-dev:11.0-website-sale-fix-fja branch from a6fc00d to ecb56fc Sep 30, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 30, 2019
@qsm-odoo qsm-odoo force-pushed the odoo-dev:11.0-website-sale-fix-fja branch from ecb56fc to e7f9fd9 Oct 9, 2019
@robodoo robodoo removed the CI 🤖 label Oct 9, 2019
Copy link
Contributor

left a comment

@robodoo robodoo added the r+ 👌 label Oct 9, 2019
shop page link and popover use the same route which make a write on db
to recompute coupon lines. Can lead to concurent updates if unlucky on
timing.

task-2070507
@qsm-odoo qsm-odoo force-pushed the odoo-dev:11.0-website-sale-fix-fja branch from e7f9fd9 to 275fcd3 Oct 10, 2019
@robodoo robodoo removed the r+ 👌 label Oct 10, 2019
@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

robodoo pushed a commit that referenced this pull request Oct 10, 2019
shop page link and popover use the same route which make a write on db
to recompute coupon lines. Can lead to concurent updates if unlucky on
timing.

task-2070507

closes #37141

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

Merged at b5cffa8, thanks!

@robodoo robodoo closed this Oct 10, 2019
@qsm-odoo qsm-odoo deleted the odoo-dev:11.0-website-sale-fix-fja branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.