Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saas 12.5 related binary rco seb #37216

Closed

Conversation

@seb-odoo
Copy link
Contributor

commented Sep 20, 2019

rebase-ff or do we write a merge message here and a proper title?

@robodoo robodoo added the seen 🙂 label Sep 20, 2019
@seb-odoo seb-odoo force-pushed the odoo-dev:saas-12.5-related-binary-rco-seb branch from 5411333 to 618dd3a Sep 20, 2019
@seb-odoo seb-odoo self-assigned this Sep 20, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Sep 20, 2019
@rco-odoo rco-odoo force-pushed the odoo-dev:saas-12.5-related-binary-rco-seb branch from ce3987b to 0d844c3 Sep 23, 2019
@robodoo robodoo removed the CI 🤖 label Sep 23, 2019
odoo/addons/base/models/ir_attachment.py Outdated Show resolved Hide resolved
odoo/fields.py Outdated Show resolved Hide resolved
odoo/fields.py Outdated Show resolved Hide resolved
odoo/models.py Outdated Show resolved Hide resolved
@seb-odoo seb-odoo force-pushed the odoo-dev:saas-12.5-related-binary-rco-seb branch 2 times, most recently from 01e0146 to c2fca2e Sep 23, 2019
@seb-odoo seb-odoo marked this pull request as ready for review Sep 23, 2019
@robodoo robodoo added the CI 🤖 label Sep 23, 2019
@seb-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2019

Runbot green here + enterprise

Copy link
Member

left a comment

@robodoo rebase-ff r+

@robodoo robodoo added the r+ 👌 label Sep 23, 2019
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

Merge method set to rebase and fast-forward

robodoo pushed a commit that referenced this pull request Sep 23, 2019
The format of `many2one_reference` was not introduced when the new field type
was created, which leads to errors when the web client is trying to display the
value of such fields.

Since the value of this field is an ID, it is decided to display it like an
integer, which is consistent with previous behavior: the fields that are now
`many2one_reference` are still stored as integer and they were already displayed
as integer before.

closes #37216

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
The format of `many2one_reference` was not introduced when the new field type
was created, which leads to errors when the web client is trying to display the
value of such fields.

Since the value of this field is an ID, it is decided to display it like an
integer, which is consistent with previous behavior: the fields that are now
`many2one_reference` are still stored as integer and they were already displayed
as integer before.
@seb-odoo seb-odoo force-pushed the odoo-dev:saas-12.5-related-binary-rco-seb branch from c2fca2e to b4d1a4f Sep 23, 2019
@robodoo robodoo removed the error 🙅 label Sep 23, 2019
@seb-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2019

Rebased. Can't reproduce issue locally.

@robodoo robodoo added the CI 🤖 label Sep 23, 2019
@rco-odoo

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

@robodoo robodoo added the r+ 👌 label Sep 24, 2019
robodoo pushed a commit that referenced this pull request Sep 24, 2019
The format of `many2one_reference` was not introduced when the new field type
was created, which leads to errors when the web client is trying to display the
value of such fields.

Since the value of this field is an ID, it is decided to display it like an
integer, which is consistent with previous behavior: the fields that are now
`many2one_reference` are still stored as integer and they were already displayed
as integer before.

closes #37216

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2019

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/630001)

@rco-odoo

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

@seb-odoo the issue should be fixed by #37341.

@seb-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

Thank you for the notice, I was about to investigate further.

Apparently the failing test has been disabled from staging branches.

@robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Sep 24, 2019
robodoo pushed a commit that referenced this pull request Sep 24, 2019
The format of `many2one_reference` was not introduced when the new field type
was created, which leads to errors when the web client is trying to display the
value of such fields.

Since the value of this field is an ID, it is decided to display it like an
integer, which is consistent with previous behavior: the fields that are now
`many2one_reference` are still stored as integer and they were already displayed
as integer before.

closes #37216

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
robodoo pushed a commit that referenced this pull request Sep 24, 2019
The format of `many2one_reference` was not introduced when the new field type
was created, which leads to errors when the web client is trying to display the
value of such fields.

Since the value of this field is an ID, it is decided to display it like an
integer, which is consistent with previous behavior: the fields that are now
`many2one_reference` are still stored as integer and they were already displayed
as integer before.

closes #37216

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
robodoo pushed a commit that referenced this pull request Sep 24, 2019
The format of `many2one_reference` was not introduced when the new field type
was created, which leads to errors when the web client is trying to display the
value of such fields.

Since the value of this field is an ID, it is decided to display it like an
integer, which is consistent with previous behavior: the fields that are now
`many2one_reference` are still stored as integer and they were already displayed
as integer before.

closes #37216

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
robodoo pushed a commit that referenced this pull request Sep 24, 2019
The format of `many2one_reference` was not introduced when the new field type
was created, which leads to errors when the web client is trying to display the
value of such fields.

Since the value of this field is an ID, it is decided to display it like an
integer, which is consistent with previous behavior: the fields that are now
`many2one_reference` are still stored as integer and they were already displayed
as integer before.

closes #37216

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
robodoo pushed a commit that referenced this pull request Sep 24, 2019
The format of `many2one_reference` was not introduced when the new field type
was created, which leads to errors when the web client is trying to display the
value of such fields.

Since the value of this field is an ID, it is decided to display it like an
integer, which is consistent with previous behavior: the fields that are now
`many2one_reference` are still stored as integer and they were already displayed
as integer before.

closes #37216

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
@robodoo robodoo added merged 🎉 and removed merging 👷 labels Sep 24, 2019
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2019

Merged at d0c852f, thanks!

@robodoo robodoo closed this Sep 24, 2019
@rco-odoo rco-odoo deleted the odoo-dev:saas-12.5-related-binary-rco-seb branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.