Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_theme_install: theme installation #38209

Closed
wants to merge 1 commit into from

Conversation

@rco-odoo
Copy link
Member

commented Oct 8, 2019

Group the upgrade of upstream dependencies with the installation of a
new theme into a single install/upgrade operation. This fixes cache
misses occurring when accessing the state of a module after having
upgraded other modules.

Co-authored-by: Sébastien Theys seb@odoo.com

@rco-odoo rco-odoo requested a review from qsm-odoo Oct 8, 2019
@robodoo robodoo added the seen 🙂 label Oct 8, 2019
@C3POdoo C3POdoo added the RD label Oct 8, 2019
@qsm-odoo

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

@robodoo delegate=rdeodoo

If it is ok for everyone, it is ok for me ;) ... python ... 😨

@robodoo robodoo added the CI 🤖 label Oct 8, 2019
@seb-odoo seb-odoo self-assigned this Oct 8, 2019
@rdeodoo

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

Seems fine to me at first look, yet to check more complexe flow but it fixes the issue when switching theme.

@robodoo robodoo removed the CI 🤖 label Oct 9, 2019
@rco-odoo rco-odoo force-pushed the odoo-dev:13.0-theme-install-rco branch 2 times, most recently from 1f1bcd0 to f779fa8 Oct 9, 2019
Copy link
Contributor

left a comment

Looks good to me with the latest changes. Commit can be squashed and merged.

I did a few tests and everything seems ok. This is as good as it is going to get until we have proper tests in place for this.

@robodoo robodoo added the CI 🤖 label Oct 9, 2019
Group the upgrade of upstream dependencies with the installation of a
new theme into a single install/upgrade operation.  This fixes cache
misses occurring when accessing the state of a module after having
upgraded other modules.

Co-authored-by: Sébastien Theys <seb@odoo.com>
@rco-odoo rco-odoo force-pushed the odoo-dev:13.0-theme-install-rco branch from f779fa8 to f77e4e4 Oct 9, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 9, 2019
@seb-odoo

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@robodoo robodoo added the r+ 👌 label Oct 9, 2019
@robodoo robodoo added the merging 👷 label Oct 9, 2019
@robodoo robodoo closed this in 03b796b Oct 9, 2019
@robodoo robodoo added merged 🎉 and removed merging 👷 labels Oct 9, 2019
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

Merged at 03b796b, thanks!

@rdeodoo rdeodoo deleted the odoo-dev:13.0-theme-install-rco branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.