Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] account: Control Access: Journals that can be allowed by accounts #38255

Open
wants to merge 1 commit into
base: master
from

Conversation

@william-andre
Copy link
Contributor

commented Oct 9, 2019

Task 2074811

Allow to specify on an account the journals that can be allowed

Example of use case :
I create an IFRS journal and some specific IFRS accounts
I want to make sure that the accounts I configured for the IFRS are only use to make entries in the IFRS journal

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Oct 9, 2019
@C3POdoo C3POdoo added the RD label Oct 9, 2019
@william-andre william-andre force-pushed the odoo-dev:master-allowed-journals-wan branch from 196acfc to 59a3ab0 Oct 9, 2019
@robodoo robodoo added the CI 🤖 label Oct 9, 2019
@william-andre william-andre force-pushed the odoo-dev:master-allowed-journals-wan branch from 59a3ab0 to 3efea50 Oct 10, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 10, 2019
Copy link
Contributor

left a comment

some minor remarks

addons/account/models/account.py Show resolved Hide resolved
addons/account/models/account_move.py Show resolved Hide resolved
addons/account/models/account.py Outdated Show resolved Hide resolved
addons/account/models/chart_template.py Outdated Show resolved Hide resolved
addons/account/views/account_view.xml Show resolved Hide resolved
@william-andre william-andre force-pushed the odoo-dev:master-allowed-journals-wan branch from 3efea50 to 8a562f6 Oct 16, 2019
@robodoo robodoo removed the CI 🤖 label Oct 16, 2019
Task 2074811

Allow to specify on an account the journals that can be allowed

Example of use case :
* I create an IFRS journal and some specific IFRS accounts
* I want to make sure that the accounts I configured for the IFRS are
  only use to make entries in the IFRS journal

In this commit we also prevent from changing the configuration of a
journal if there are account.move.line that should not have been allowed
to be created with the new configuration.
@william-andre william-andre force-pushed the odoo-dev:master-allowed-journals-wan branch from 8a562f6 to 8c29735 Oct 16, 2019
@robodoo robodoo added the CI 🤖 label Oct 16, 2019
@qdp-odoo

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2019

you need to add some tests, otherwise the whole PR is okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.