Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] snailmail_account: send multiple invoices #38264

Closed
wants to merge 1 commit into from

Conversation

@Feyensv
Copy link
Contributor

commented Oct 9, 2019

  • Ensure compute always sets partner_id.
  • Don't show "to" when partner_id is not set

FIX "Send & Print" Action on account.move model.

Fixes #38228

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

* Ensure compute always sets partner_id.
* Don't show "to" when partner_id is not set
@robodoo robodoo added the seen 🙂 label Oct 9, 2019
@C3POdoo C3POdoo added the RD label Oct 9, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 9, 2019
@Feyensv Feyensv requested a review from tde-banana-odoo Oct 9, 2019
@Feyensv Feyensv changed the title [FIX] snailmail_account: send multiple invoices [FIX] snailmail_account, mail: send multiple invoices Oct 9, 2019
@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

I don't know what you are trying to do as you commit message does not explain anything useful, but

1/ probably not linked to 13
2/ no test case, no merge

Thanks,

@robodoo robodoo added the CI 🤖 label Oct 9, 2019
@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

If pop, you can go without test. Probably make initial fix in 11, to check (for mail stuff at least).

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@smetl ping for accounting part

@Feyensv Feyensv force-pushed the odoo-dev:13.0-fix-4-vfe branch from dfae707 to 4bd482f Oct 9, 2019
@Feyensv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

@robodoo robodoo added the r+ 👌 label Oct 9, 2019
@Feyensv Feyensv changed the title [FIX] snailmail_account, mail: send multiple invoices [FIX] snailmail_account: send multiple invoices Oct 9, 2019
robodoo pushed a commit that referenced this pull request Oct 9, 2019
* Ensure compute always sets partner_id.
* Don't show "to" when partner_id is not set

closes #38264

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
@robodoo robodoo added the merging 👷 label Oct 9, 2019
robodoo pushed a commit that referenced this pull request Oct 9, 2019
* Ensure compute always sets partner_id.
* Don't show "to" when partner_id is not set

closes #38264

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
robodoo pushed a commit that referenced this pull request Oct 9, 2019
* Ensure compute always sets partner_id.
* Don't show "to" when partner_id is not set

closes #38264

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

Staging failed: ci/runbot on f7098b721c6028c0b9df9ca1afb2b02902ef6154 (view more at http://runbot.odoo.com/runbot/build/645916)

@Feyensv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

@robodoo retry

@robodoo robodoo added CI 🤖 r+ 👌 and removed error 🙅 labels Oct 9, 2019
@robodoo robodoo added the merging 👷 label Oct 9, 2019
@robodoo robodoo closed this in 7e12214 Oct 9, 2019
@robodoo robodoo added merged 🎉 and removed merging 👷 labels Oct 9, 2019
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

Merged at 7e12214, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.