Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] base export: Manage False in group by title #38288

Conversation

@jbm-odoo
Copy link
Contributor

commented Oct 9, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:
Before this commit, when we export a list with a group by on
Boolean, the group by title 'False' is replaced by 'Undefined'
in xls document.

Desired behavior after PR is merged:
After this commit, with an export and group by on a Boolean, we
will have correct title: True and False.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@jbm-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

@robodoo robodoo added the seen 🙂 label Oct 9, 2019
@C3POdoo C3POdoo added the RD label Oct 9, 2019
@robodoo robodoo added the CI 🤖 label Oct 9, 2019
Before this commit, when we export a list with a groupby on
boolean, the groupby title 'False' is replaced by 'Undefined'
in xls document.

After this commit, with an export and groupby on a boolean, we
will have correct title: True and False.
@jbm-odoo jbm-odoo force-pushed the odoo-dev:13.0-fix-export-manage-groupby-boolean-false-jbm branch from ab87456 to 2cec753 Oct 10, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 10, 2019
@LucasLefevre

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

This commit has been cherry picked to #38373

@robodoo robodoo added closed 💔 and removed CI 🤖 labels Oct 10, 2019
@tivisse tivisse deleted the odoo-dev:13.0-fix-export-manage-groupby-boolean-false-jbm branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.